public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: "Burak Kaan Karaçay" <bkkaracay@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, christian.couder@gmail.com,
	"Burak Kaan Karaçay" <bkkaracay@gmail.com>
Subject: [GSOC PATCH v2 0/2] mailmap: reduce global state
Date: Fri, 20 Feb 2026 09:04:40 +0300	[thread overview]
Message-ID: <20260220060442.29469-1-bkkaracay@gmail.com> (raw)
In-Reply-To: <20260219125954.3539324-1-bkkaracay@gmail.com>

Hi,

This patch series aims to reduce the global variable dependency of the
mailmap subsystem:

  - Patch 1 eliminates the implicit 'the_repository' dependency in the
    'read_mailmap' and 'read_mailmap_blob' functions by adding a
    'struct repository' parameter.

  - Patch 2 removes the 'git_mailmap_file' and 'git_mailmap_blob' global
    variables, shifting to on-demand configuration reading via the config
    set helpers and using local variables.
    
Changes in v2:
  - Forward declare 'struct repository' in mailmap.h
  - Fix whitespace problems

Thanks to Junio for the kind words and for catching the 'make hdr-check' issue.

Burak Kaan Karaçay (2):
  mailmap: stop using the_repository
  mailmap: drop global config variables

 builtin/blame.c         |  2 +-
 builtin/cat-file.c      |  2 +-
 builtin/check-mailmap.c |  4 ++--
 builtin/commit.c        |  2 +-
 builtin/log.c           |  2 +-
 builtin/shortlog.c      |  2 +-
 environment.c           | 19 -------------------
 mailmap.c               | 30 +++++++++++++++++++-----------
 mailmap.h               |  9 ++++-----
 pretty.c                |  2 +-
 ref-filter.c            |  2 +-
 11 files changed, 32 insertions(+), 44 deletions(-)

-- 
2.52.0


  parent reply	other threads:[~2026-02-20  6:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 12:59 [GSOC PATCH 0/2] mailmap: reduce global state Burak Kaan Karaçay
2026-02-19 12:59 ` [GSOC PATCH 1/2] mailmap: stop using the_repository Burak Kaan Karaçay
2026-02-19 12:59 ` [GSOC PATCH 2/2] mailmap: drop global config variables Burak Kaan Karaçay
2026-02-19 21:22 ` [GSOC PATCH 0/2] mailmap: reduce global state Junio C Hamano
2026-02-19 22:50   ` Junio C Hamano
2026-02-20  6:04 ` Burak Kaan Karaçay [this message]
2026-02-20  6:04   ` [GSOC PATCH v2 1/2] mailmap: stop using the_repository Burak Kaan Karaçay
2026-02-20  6:04   ` [GSOC PATCH v2 2/2] mailmap: drop global config variables Burak Kaan Karaçay
2026-02-20 16:16   ` [GSOC PATCH v2 0/2] mailmap: reduce global state Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260220060442.29469-1-bkkaracay@gmail.com \
    --to=bkkaracay@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox