public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Karan GB bhatrekaran83@gmail.com
To: git@vger.kernel.org
Cc: KaranGB83 <bhatrekaran83@gmail.com>
Subject: [PATCH] added error lines for no 'want' line in git upload pack
Date: Sat, 21 Feb 2026 19:48:41 +0000	[thread overview]
Message-ID: <20260221194851.84071-1-bhatrekaran83@gmail.com> (raw)

From: KaranGB83 <bhatrekaran83@gmail.com>

Signed-off-by: KaranGB83 <bhatrekaran83@gmail.com>
---
 Documentation/gitprotocol-http.adoc | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/Documentation/gitprotocol-http.adoc b/Documentation/gitprotocol-http.adoc
index e2ef7f0459..0f735de216 100644
--- a/Documentation/gitprotocol-http.adoc
+++ b/Documentation/gitprotocol-http.adoc
@@ -440,7 +440,15 @@ The server MAY walk backwards through history or through
 the reflog to permit slightly stale requests.
 
 If no "want" objects are received, send an error:
-TODO: Define error if no "want" lines are requested.
+Then the server must treat the request as INVALID and the 
+terminate the negotiation.
+
+the server responds with:
+
+   S: ERR no wants received
+
+It indicates that client failed to specify any object to fetch.
+The server must not continue when no `want` lines are provided.
 
 If any "want" object is not reachable, send an error:
 When a Git server receives an invalid or malformed `want` line, it
-- 
2.53.0.154.g7c02d39fc2


                 reply	other threads:[~2026-02-21 19:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260221194851.84071-1-bhatrekaran83@gmail.com \
    --to=git@vger.kernel.org \
    --cc=bhatrekaran83@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox