From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2511E2BEC2B for ; Sat, 28 Feb 2026 04:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772251663; cv=none; b=UNbqQdWz7JTcU8xqXUhx3RQX8pcLKJsAAckfo7NlnpTIIhvpFDnb62hISlr0OJLG9eZKOlmJl/JSCXS3WBAbRpc69+gvvTeLo5qpEvzTiMdeKoOCgLZXd5rKOkgTwXCBpBzvI6N6MSYPbD5ioLfdGL6IahoyeOKyraGm+lEycVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772251663; c=relaxed/simple; bh=4o2BvF7UuNZS1ZCrkSgebZYqXoMmaHKZ0H6oF9Vn+8Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AUmZKGFBUvirkbopPU/avP3QhqlWdCCPKPCOWW3j+bgA+Q04rsNcwUONOMKhaRSDKN/PxQxad536Vi9McBv08wQx0WClR5P/kQ8pQvzKsPgmVi05iiow0qVq1MxC631fZvaOi6B+De/yGFY56f+y/7dWC6EjrIUk4SvVVVBjtR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=beEcx9xU; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="beEcx9xU" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3597b05a68cso3582a91.3 for ; Fri, 27 Feb 2026 20:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772251661; x=1772856461; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kTFGipjswlBQYX4+xFPfQ2ml1EZU2zvg1LbESlesmZc=; b=beEcx9xUNJJ8aofX2Bx2tgpYmqILQ00cxCxloojvkRhOXmp+FbOxVTz6uIK2155sfb oeGns6bQOv5N1s8EZlwRPl8wpzZKufGnMCqKnU7mx2LJN7kLcOHradNgws28lYGA7evs sxmIYzS7uSIiAXHW0Gw3EklWqexUv5012LnhxmfVj0wVdD+vJqqE0aZz/sGxQgd0fnie yccX46SvaNVH/Pmt0YUxNckObev/DQ1LczOxNY+Jx42LtUP4iFW33vK3nxsmmt0RZQRT uoFUYXCNTiH4cDzojm3k44VBl2aPP5KMoSmOxuQY04tcjOhflYxl+cJ8KxVYfHXv7r94 UVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772251661; x=1772856461; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kTFGipjswlBQYX4+xFPfQ2ml1EZU2zvg1LbESlesmZc=; b=M6DFsOeyfny6jDRRKykZ4SQCK8E15WACi3mB5r2AJp1KK+3mkTYHih7sdAyj1XO/Q8 Usy6FgVhRjI2rKWdVOY25FPPdMcf+c3JbvAdBXfmOlgdSBFB/wUJxavtB95065ahJiTB skVUOmRsOD9IoSuSiGQbnL9SU5ZE3BBIyIw9739uAWIUgztO5kXQEuvrbZJLn1UyKX92 pxRmg6wsiXz5VraiLsmPZuT9sEfs/9vs5/sAOzL/pqXEEeraYvhfeEkxeRITlj5OXKa1 lJNGTLI5hK3NZS9R7/5pkdGrOQ/h0trWgO0fwE0RgF9e+zB1h2PBiAa2g5esmkxBgM4O JDGg== X-Gm-Message-State: AOJu0YyG6ANBCLPM62yj86t0KiyOMNRuSHrFfjuJLo+xjzthYM0ac+fw vNr32QC01OAK1uudVTj5L7Hp7F7ijCCY3+7nTbcLBcZFP1ElEKa6aJqMjYAxS497 X-Gm-Gg: ATEYQzzLOz3t0Ignd64A++CYfi5giFVnNV9xoYpMSPIwNmNGrvNJ/6MLN5Uo5QSVQrV Sgr5IuMM7g24RH5SjETEWsiHkhRhGdyzSsGVWeZBuybtfu7Rbqc8M9IL1lKO9P5WZgEi7+ZBttZ Uu2MUhWwCHMzTyWe9reIDdwXddmT79aZxpiVJ1vTSaiVL4c/dqqK0Qy7R/d9bQ0cHIqv+EXPQek mg0Gv/4s4QXPeBbExSSa4/AjXptk/almW5M5LqkWwA+D8i3D0COqpJBLMUgl7tGRpGANqRI/kFX pLq/HccEG4hkY61L5NISwNPpYI9ixunkQSmiQc2oOoSioIVmvKWIPB/dfN5ELxZ9w4VbErZqdgv 88qauQNHxHNJVHuI+DwCAHvZptybC2i95DuFoCvpXQ6p7QP4acW8Zkjh3yhU3Eyrejxxx/koJMS Q5ErinCPrcVOHEoDcjDEBoEQY0SVOBTIoL6+km/Rg= X-Received: by 2002:a17:90a:d60f:b0:356:24f0:af05 with SMTP id 98e67ed59e1d1-35965c2d04emr3505690a91.1.1772251660909; Fri, 27 Feb 2026 20:07:40 -0800 (PST) Received: from malon-Yoga-14sARE-2020.. ([155.69.180.3]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3593dcad63esm7998031a91.2.2026.02.27.20.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 20:07:40 -0800 (PST) From: Tian Yuchen To: git@vger.kernel.org Cc: gitster@pobox.com, karthik.188@gmail.com Subject: [PATCH v1] environment: migrate encoding settings to repo-settings Date: Sat, 28 Feb 2026 12:07:27 +0800 Message-ID: <20260228040727.2057192-1-a3205153416@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Global variables 'git_commit_encoding' and 'git_log_output_encoding' hinder the ongoing libification effort by binding functions to a single global state. Move both variables into 'struct repo_settings' to enable lazy loading. They are migrated together in this patch because the log encoding directly falls back to the commit encoding. Update callers to use the new 'repo_get_commit_output_encoding()' and 'repo_get_log_output_encoding()' apis. Functions now accept 'struct repository' to bubble up dependency where possible. For callers in the 'builtin/' directory, and for core library functions that do not yet receive a repository context, 'the_repository' is used as a fallback. Additionally, in 'revision.c', ensure 'prepare_repo_settings()' is triggered before CLI overrides, for example, '--encoding', to prevent lazy-loading from mistakenly overwriting command-line choice later. All tests passed, no memory leak. Signed-off-by: Tian Yuchen --- This patch serves as a proof of concept for migration workflow preposed in my GSoC 2026 proposal, regarding global state libification. The patch has been verified against the full test suite and compiled with 'SANITIZE=address,undefined' to ensure clean memory ownership. Any thought on whether this patch meets the project's standards would be deeply appreciated. Regards, Yuchen builtin/am.c | 4 ++-- builtin/blame.c | 2 +- builtin/commit.c | 6 +++--- builtin/log.c | 2 +- builtin/mailinfo.c | 2 +- builtin/rev-list.c | 2 +- builtin/shortlog.c | 2 +- bundle.c | 2 +- commit.c | 6 +++--- environment.c | 37 +++++++++++-------------------------- environment.h | 7 ++----- log-tree.c | 4 ++-- pretty.c | 2 +- remote-curl.c | 3 ++- replay.c | 2 +- repo-settings.c | 7 +++++++ repo-settings.h | 3 +++ revision.c | 11 ++++++----- sequencer.c | 16 ++++++++-------- submodule.c | 2 +- 20 files changed, 58 insertions(+), 64 deletions(-) diff --git a/builtin/am.c b/builtin/am.c index e0c767e223..96b8c00007 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -1216,7 +1216,7 @@ static int parse_mail(struct am_state *state, const char *mail) setup_mailinfo(the_repository, &mi); if (state->utf8) - mi.metainfo_charset = get_commit_output_encoding(); + mi.metainfo_charset = repo_get_commit_output_encoding(the_repository); else mi.metainfo_charset = NULL; @@ -1355,7 +1355,7 @@ static void get_commit_info(struct am_state *state, struct commit *commit) struct ident_split id; buffer = repo_logmsg_reencode(the_repository, commit, NULL, - get_commit_output_encoding()); + repo_get_commit_output_encoding(the_repository)); ident_line = find_commit_header(buffer, "author", &ident_len); if (!ident_line) diff --git a/builtin/blame.c b/builtin/blame.c index eac2fe7320..cc82182c51 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -202,7 +202,7 @@ static void get_commit_info(struct commit *commit, struct commit_info *ret) const char *subject, *encoding; const char *message; - encoding = get_log_output_encoding(); + encoding = repo_get_log_output_encoding(the_repository); message = repo_logmsg_reencode(the_repository, commit, NULL, encoding); get_ac_line(message, "\nauthor ", &ret->author, &ret->author_mail, diff --git a/builtin/commit.c b/builtin/commit.c index 9e3a09d532..2bbdd4c4c3 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -794,7 +794,7 @@ static int prepare_to_commit(const char *index_file, const char *prefix, c = lookup_commit_reference_by_name(squash_message); if (!c) die(_("could not lookup commit '%s'"), squash_message); - ctx.output_encoding = get_commit_output_encoding(); + ctx.output_encoding = repo_get_commit_output_encoding(the_repository); repo_format_commit_message(the_repository, c, "squash! %s\n\n", &sb, &ctx); @@ -829,7 +829,7 @@ static int prepare_to_commit(const char *index_file, const char *prefix, commit = lookup_commit_reference_by_name(fixup_commit); if (!commit) die(_("could not lookup commit '%s'"), fixup_commit); - ctx.output_encoding = get_commit_output_encoding(); + ctx.output_encoding = repo_get_commit_output_encoding(the_repository); fmt = xstrfmt("%s! %%s\n\n", fixup_prefix); repo_format_commit_message(the_repository, commit, fmt, &sb, &ctx); @@ -1235,7 +1235,7 @@ static const char *read_commit_message(const char *name) commit = lookup_commit_reference_by_name(name); if (!commit) die(_("could not lookup commit '%s'"), name); - out_enc = get_commit_output_encoding(); + out_enc = repo_get_commit_output_encoding(the_repository); return repo_logmsg_reencode(the_repository, commit, NULL, out_enc); } diff --git a/builtin/log.c b/builtin/log.c index 8ab6d3a943..1c9ec09098 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -568,7 +568,7 @@ static void show_tagger(const char *buf, struct rev_info *rev) pp.fmt = rev->commit_format; pp.date_mode = rev->date_mode; - pp_user_info(&pp, "Tagger", &out, buf, get_log_output_encoding()); + pp_user_info(&pp, "Tagger", &out, buf, repo_get_log_output_encoding(the_repository)); fprintf(rev->diffopt.file, "%s", out.buf); strbuf_release(&out); } diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c index 8de7ba7de1..eab4e05850 100644 --- a/builtin/mailinfo.c +++ b/builtin/mailinfo.c @@ -93,7 +93,7 @@ int cmd_mailinfo(int argc, switch (meta_charset.policy) { case CHARSET_DEFAULT: - mi.metainfo_charset = get_commit_output_encoding(); + mi.metainfo_charset = repo_get_commit_output_encoding(the_repository); break; case CHARSET_NO_REENCODE: mi.metainfo_charset = NULL; diff --git a/builtin/rev-list.c b/builtin/rev-list.c index ddea8aa251..3c6a2914d8 100644 --- a/builtin/rev-list.c +++ b/builtin/rev-list.c @@ -304,7 +304,7 @@ static void show_commit(struct commit *commit, void *data) ctx.date_mode = revs->date_mode; ctx.date_mode_explicit = revs->date_mode_explicit; ctx.fmt = revs->commit_format; - ctx.output_encoding = get_log_output_encoding(); + ctx.output_encoding = repo_get_log_output_encoding(the_repository); ctx.color = revs->diffopt.use_color; ctx.rev = revs; pretty_print_commit(&ctx, commit, &buf); diff --git a/builtin/shortlog.c b/builtin/shortlog.c index d80bf1a7d0..ce9f20de2f 100644 --- a/builtin/shortlog.c +++ b/builtin/shortlog.c @@ -248,7 +248,7 @@ void shortlog_add_commit(struct shortlog *log, struct commit *commit) ctx.fmt = CMIT_FMT_USERFORMAT; ctx.abbrev = log->abbrev; ctx.date_mode = log->date_mode; - ctx.output_encoding = get_log_output_encoding(); + ctx.output_encoding = repo_get_log_output_encoding(the_repository); if (!log->summary) { if (log->user_format) diff --git a/bundle.c b/bundle.c index 42327f9739..7914a57b43 100644 --- a/bundle.c +++ b/bundle.c @@ -461,7 +461,7 @@ static void write_bundle_prerequisites(struct commit *commit, void *data) write_or_die(bpi->fd, buf.buf, buf.len); ctx.fmt = CMIT_FMT_ONELINE; - ctx.output_encoding = get_log_output_encoding(); + ctx.output_encoding = repo_get_log_output_encoding(the_repository); strbuf_reset(&buf); pretty_print_commit(&ctx, commit, &buf); strbuf_trim(&buf); diff --git a/commit.c b/commit.c index d16ae73345..d558db52dc 100644 --- a/commit.c +++ b/commit.c @@ -1673,7 +1673,7 @@ static void write_commit_tree(struct strbuf *buffer, const char *msg, size_t msg size_t i; /* Not having i18n.commitencoding is the same as having utf-8 */ - encoding_is_utf8 = is_encoding_utf8(git_commit_encoding); + encoding_is_utf8 = is_encoding_utf8(repo_get_commit_output_encoding(the_repository)); strbuf_grow(buffer, 8192); /* should avoid reallocs for the headers */ strbuf_addf(buffer, "tree %s\n", oid_to_hex(tree)); @@ -1694,7 +1694,7 @@ static void write_commit_tree(struct strbuf *buffer, const char *msg, size_t msg committer = git_committer_info(IDENT_STRICT); strbuf_addf(buffer, "committer %s\n", committer); if (!encoding_is_utf8) - strbuf_addf(buffer, "encoding %s\n", git_commit_encoding); + strbuf_addf(buffer, "encoding %s\n", repo_get_commit_output_encoding(the_repository)); while (extra) { add_extra_header(buffer, extra); @@ -1723,7 +1723,7 @@ int commit_tree_extended(const char *msg, size_t msg_len, size_t i, nparents; /* Not having i18n.commitencoding is the same as having utf-8 */ - encoding_is_utf8 = is_encoding_utf8(git_commit_encoding); + encoding_is_utf8 = is_encoding_utf8(repo_get_commit_output_encoding(the_repository)); odb_assert_oid_type(the_repository->objects, tree, OBJ_TREE); diff --git a/environment.c b/environment.c index 0026eb2274..9c2a26c3c1 100644 --- a/environment.c +++ b/environment.c @@ -50,8 +50,6 @@ int ignore_case; int assume_unchanged; int is_bare_repository_cfg = -1; /* unspecified */ int warn_on_object_refname_ambiguity = 1; -char *git_commit_encoding; -char *git_log_output_encoding; char *apply_default_whitespace; char *apply_default_ignorewhitespace; char *git_attributes_file; @@ -197,15 +195,21 @@ const char *strip_namespace(const char *namespaced_ref) return NULL; } -const char *get_log_output_encoding(void) +const char *repo_get_log_output_encoding(struct repository *r) { - return git_log_output_encoding ? git_log_output_encoding - : get_commit_output_encoding(); + prepare_repo_settings(r); + + return r->settings.log_output_encoding ? + r->settings.log_output_encoding : + repo_get_commit_output_encoding(r); } -const char *get_commit_output_encoding(void) +const char *repo_get_commit_output_encoding(struct repository *r) { - return git_commit_encoding ? git_commit_encoding : "UTF-8"; + prepare_repo_settings(r); + + return r->settings.commit_encoding ? + r->settings.commit_encoding : "UTF-8"; } int use_optional_locks(void) @@ -566,22 +570,6 @@ static int git_default_sparse_config(const char *var, const char *value) return 0; } -static int git_default_i18n_config(const char *var, const char *value) -{ - if (!strcmp(var, "i18n.commitencoding")) { - FREE_AND_NULL(git_commit_encoding); - return git_config_string(&git_commit_encoding, var, value); - } - - if (!strcmp(var, "i18n.logoutputencoding")) { - FREE_AND_NULL(git_log_output_encoding); - return git_config_string(&git_log_output_encoding, var, value); - } - - /* Add other config variables here and to Documentation/config.adoc. */ - return 0; -} - static int git_default_branch_config(const char *var, const char *value) { if (!strcmp(var, "branch.autosetupmerge")) { @@ -688,9 +676,6 @@ int git_default_config(const char *var, const char *value, starts_with(var, "committer.")) return git_ident_config(var, value, ctx, cb); - if (starts_with(var, "i18n.")) - return git_default_i18n_config(var, value); - if (starts_with(var, "branch.")) return git_default_branch_config(var, value); diff --git a/environment.h b/environment.h index 27f657af04..eba8d5786c 100644 --- a/environment.h +++ b/environment.h @@ -193,11 +193,8 @@ extern enum object_creation_mode object_creation_mode; extern int grafts_keep_true_parents; -const char *get_log_output_encoding(void); -const char *get_commit_output_encoding(void); - -extern char *git_commit_encoding; -extern char *git_log_output_encoding; +const char *repo_get_log_output_encoding(struct repository *r); +const char *repo_get_commit_output_encoding(struct repository *r); extern char *editor_program; extern char *askpass_program; diff --git a/log-tree.c b/log-tree.c index 7e048701d0..aea3cbf7c6 100644 --- a/log-tree.c +++ b/log-tree.c @@ -859,7 +859,7 @@ void show_log(struct rev_info *opt) raw = (opt->commit_format == CMIT_FMT_USERFORMAT); format_display_notes(&commit->object.oid, ¬ebuf, - get_log_output_encoding(), raw); + repo_get_log_output_encoding(the_repository), raw); ctx.notes_message = strbuf_detach(¬ebuf, NULL); } @@ -879,7 +879,7 @@ void show_log(struct rev_info *opt) ctx.mailmap = opt->mailmap; ctx.color = opt->diffopt.use_color; ctx.expand_tabs_in_log = opt->expand_tabs_in_log; - ctx.output_encoding = get_log_output_encoding(); + ctx.output_encoding = repo_get_log_output_encoding(the_repository); ctx.rev = opt; if (opt->from_ident.mail_begin && opt->from_ident.name_begin) ctx.from_ident = &opt->from_ident; diff --git a/pretty.c b/pretty.c index e0646bbc5d..e939d0ff3b 100644 --- a/pretty.c +++ b/pretty.c @@ -2298,7 +2298,7 @@ void pretty_print_commit(struct pretty_print_context *pp, return; } - encoding = get_log_output_encoding(); + encoding = repo_get_log_output_encoding(the_repository); msg = reencoded = repo_logmsg_reencode(the_repository, commit, NULL, encoding); diff --git a/remote-curl.c b/remote-curl.c index 92e40bb682..cd7e5e701a 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -379,7 +379,8 @@ static int show_http_message(struct strbuf *type, struct strbuf *charset, if (strcmp(type->buf, "text/plain")) return -1; if (charset->len) - strbuf_reencode(msg, charset->buf, get_log_output_encoding()); + strbuf_reencode(msg, charset->buf, + repo_get_log_output_encoding(the_repository)); strbuf_trim(msg); if (!msg->len) diff --git a/replay.c b/replay.c index f97d652f33..45d539f8fc 100644 --- a/replay.c +++ b/replay.c @@ -56,7 +56,7 @@ static struct commit *create_commit(struct repository *repo, char *sign_commit = NULL; /* FIXME: cli users might want to sign again */ struct commit_extra_header *extra = NULL; struct strbuf msg = STRBUF_INIT; - const char *out_enc = get_commit_output_encoding(); + const char *out_enc = repo_get_commit_output_encoding(repo); const char *message = repo_logmsg_reencode(repo, based_on, NULL, out_enc); const char *orig_message = NULL; diff --git a/repo-settings.c b/repo-settings.c index 208e09ff17..de3b4c6ef1 100644 --- a/repo-settings.c +++ b/repo-settings.c @@ -32,6 +32,7 @@ void prepare_repo_settings(struct repository *r) int experimental; int value; const char *strval; + char *alloc_strval; int manyfiles; int read_changed_paths; unsigned long ulongval; @@ -154,6 +155,12 @@ void prepare_repo_settings(struct repository *r) if (!repo_config_get_ulong(r, "core.packedgitlimit", &ulongval)) r->settings.packed_git_limit = ulongval; + + if (!repo_config_get_string(r, "i18n.commitencoding", &alloc_strval)) + r->settings.commit_encoding = alloc_strval; + + if (!repo_config_get_string(r, "i18n.logoutputencoding", &alloc_strval)) + r->settings.log_output_encoding = alloc_strval; } void repo_settings_clear(struct repository *r) diff --git a/repo-settings.h b/repo-settings.h index cad9c3f0cc..9a6b91a3a9 100644 --- a/repo-settings.h +++ b/repo-settings.h @@ -70,6 +70,9 @@ struct repo_settings { int max_allowed_tree_depth; char *hooks_path; + + char *commit_encoding; + char *log_output_encoding; }; #define REPO_SETTINGS_INIT { \ .shared_repository = -1, \ diff --git a/revision.c b/revision.c index 29972c3a19..961ecd1d6c 100644 --- a/revision.c +++ b/revision.c @@ -2675,11 +2675,12 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg } else if (!strcmp(arg, "--invert-grep")) { revs->grep_filter.no_body_match = 1; } else if ((argcount = parse_long_opt("encoding", argv, &optarg))) { - free(git_log_output_encoding); + prepare_repo_settings(revs->repo); + free(revs->repo->settings.log_output_encoding); if (strcmp(optarg, "none")) - git_log_output_encoding = xstrdup(optarg); + revs->repo->settings.log_output_encoding = xstrdup(optarg); else - git_log_output_encoding = xstrdup(""); + revs->repo->settings.log_output_encoding = xstrdup(""); return argcount; } else if (!strcmp(arg, "--reverse")) { revs->reverse ^= 1; @@ -3129,7 +3130,7 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s diff_setup_done(&revs->diffopt); - if (!is_encoding_utf8(get_log_output_encoding())) + if (!is_encoding_utf8(repo_get_log_output_encoding(the_repository))) revs->grep_filter.ignore_locale = 1; compile_grep_patterns(&revs->grep_filter); @@ -4063,7 +4064,7 @@ static int commit_match(struct commit *commit, struct rev_info *opt) * so we will not end up with a buffer that has two different encodings * in it. */ - encoding = get_log_output_encoding(); + encoding = repo_get_log_output_encoding(the_repository); message = repo_logmsg_reencode(the_repository, commit, NULL, encoding); /* Copy the commit to temporary if we are using "fake" headers */ diff --git a/sequencer.c b/sequencer.c index a3eb39bb25..612f47fd12 100644 --- a/sequencer.c +++ b/sequencer.c @@ -486,7 +486,7 @@ static int get_message(struct commit *commit, struct commit_message *out) int subject_len; out->message = repo_logmsg_reencode(the_repository, commit, NULL, - get_commit_output_encoding()); + repo_get_commit_output_encoding(the_repository)); abbrev = short_commit_name(the_repository, commit); subject_len = find_commit_subject(out->message, &subject); @@ -1539,7 +1539,7 @@ static int try_to_commit(struct repository *r, if (flags & AMEND_MSG) { const char *exclude_gpgsig[] = { "gpgsig", "gpgsig-sha256", NULL }; - const char *out_enc = get_commit_output_encoding(); + const char *out_enc = repo_get_commit_output_encoding(r); const char *message = repo_logmsg_reencode(r, current_head, NULL, out_enc); @@ -2054,7 +2054,7 @@ static int update_squash_messages(struct repository *r, struct strbuf buf = STRBUF_INIT; int res = 0; const char *message, *body; - const char *encoding = get_commit_output_encoding(); + const char *encoding = repo_get_commit_output_encoding(r); if (!is_fixup(command)) BUG("not a FIXUP or SQUASH %d", command); @@ -3344,7 +3344,7 @@ static int walk_revs_populate_todo(struct todo_list *todo_list, if (prepare_revs(opts)) return -1; - encoding = get_log_output_encoding(); + encoding = repo_get_log_output_encoding(the_repository); while ((commit = get_revision(opts->revs))) { struct todo_item *item = append_new_todo(todo_list); @@ -3730,7 +3730,7 @@ static int make_patch(struct repository *r, } if (!file_exists(rebase_path_message())) { - const char *encoding = get_commit_output_encoding(); + const char *encoding = repo_get_commit_output_encoding(r); const char *commit_buffer = repo_logmsg_reencode(r, commit, NULL, encoding); @@ -4187,7 +4187,7 @@ static int do_merge(struct repository *r, } if (commit) { - const char *encoding = get_commit_output_encoding(); + const char *encoding = repo_get_commit_output_encoding(r); const char *message = repo_logmsg_reencode(r, commit, NULL, encoding); const char *body; @@ -5311,7 +5311,7 @@ static int commit_staged_changes(struct repository *r, struct commit *commit; const char *msg; const char *path = rebase_path_squash_msg(); - const char *encoding = get_commit_output_encoding(); + const char *encoding = repo_get_commit_output_encoding(r); if (parse_head(r, &commit)) { ret = error(_("could not parse HEAD")); @@ -6092,7 +6092,7 @@ int sequencer_make_script(struct repository *r, struct strbuf *out, get_commit_format(format, &revs); free(format); pp.fmt = revs.commit_format; - pp.output_encoding = get_log_output_encoding(); + pp.output_encoding = repo_get_log_output_encoding(r); setup_revisions_from_strvec(argv, &revs, NULL); if (argv->nr > 1) { diff --git a/submodule.c b/submodule.c index 508938e4da..59f5c79d7f 100644 --- a/submodule.c +++ b/submodule.c @@ -479,7 +479,7 @@ static void print_submodule_diff_summary(struct repository *r, struct rev_info * while ((commit = get_revision(rev))) { struct pretty_print_context ctx = {0}; ctx.date_mode = rev->date_mode; - ctx.output_encoding = get_log_output_encoding(); + ctx.output_encoding = repo_get_log_output_encoding(r); strbuf_setlen(&sb, 0); repo_format_commit_message(r, commit, format, &sb, &ctx); -- 2.43.0