public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Tarjan <paul@paultarjan.com>
To: git@vger.kernel.org
Cc: sandals@crustytoothpaste.net, Paul Tarjan <github@paulisageek.com>
Subject: Re: [PATCH] fsmonitor-watchman: fix variable reference and remove redundant code
Date: Sat, 28 Feb 2026 10:33:10 -0700	[thread overview]
Message-ID: <20260228173310.97905-1-github@paulisageek.com> (raw)
In-Reply-To: <aaMiu9mDVAb6Qvyr@fruit.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> This looks like it was written by an LLM.  Is that the case, and if so,
> how does it line up with https://git-scm.com/docs/SubmittingPatches#ai?

I found these bugs during code review at my company where we use
the watchman hook. The $output vs $o mixup and the double
output_result() from the recursive call were both causing real
issues. I used Claude to help with the mechanics of formatting
and submitting the patch, and it ended up as the commit author,
which was a mistake on my part. I'll fix that in v2 with myself
as the author.

Thanks for flagging it,
Paul

  reply	other threads:[~2026-02-28 17:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26  1:33 [PATCH] fsmonitor: fix two bugs in watchman hook retry path Paul Tarjan via GitGitGadget
2026-02-08  6:03 ` Paul Tarjan
2026-02-27  6:25   ` [PATCH] fsmonitor-watchman: fix variable reference and remove redundant code Paul Tarjan
2026-02-28 17:02 ` [PATCH] fsmonitor: fix two bugs in watchman hook retry path Koji Nakamaru
2026-02-28 17:33   ` [PATCH] fsmonitor-watchman: fix variable reference and remove redundant code Paul Tarjan
2026-02-28 17:15 ` [PATCH] fsmonitor: fix two bugs in watchman hook retry path brian m. carlson
2026-02-28 17:33   ` Paul Tarjan [this message]
2026-02-28 17:37 ` [PATCH v2] fsmonitor-watchman: fix variable reference and remove redundant code Paul Tarjan via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260228173310.97905-1-github@paulisageek.com \
    --to=paul@paultarjan.com \
    --cc=git@vger.kernel.org \
    --cc=github@paulisageek.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox