Re: [PATCH 0/2] repo info: add path.git-dir and path.common-dir

[K Jayatheerth <jayatheerthkulkarni2005@gmail.com>]

> Hi,
>

Hey Pushkar,

> Following the earlier RFC discussion about exposing repository
> paths via `git repo info`, this series adds two new fields:
>
>   - path.git-dir
>   - path.common-dir
> > Hi,
>

Hey Pushkar,

> Following the earlier RFC discussion about exposing repository
> paths via `git repo info`, this series adds two new fields:
>
>   - path.git-dir
>   - path.common-dir
>


There are no updates to t/t1900-repo-info.sh.
Since path normalization can be quite tricky across
different OS environments, we absolutely need tests to
verify how path.git-dir and path.common-dir behave
under both --path-format=absolute and --path-format=relative.

For example
In both patches, if the path returns NULL, you return an error(...).
Have you tested how this behaves if a user runs git repo info --all

This is one I could think of...


> These mirror the information available through
> `git rev-parse --git-dir` and `git rev-parse --common-dir`,
> respectively.
>
> This series builds on the recent path-related changes to
> `git repo info` (including `path.toplevel` and the
> `--path-format` flag), which are currently under review.
>
> Both fields respect the `--path-format` semantics introduced
> there.
>

The new keys haven't been added to Documentation/git-repo.adoc.


> Pushkar Singh (2):
>   repo: add the field path.git-dir
>   repo: add the field path.common-dir
>
>  builtin/repo.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
>
> base-commit: 625c4fb2daac9879b299dd1cae2e793d2821dec0
> prerequisite-patch-id: a15d35d8ce98f550953b8d2b5766b945ae73013e
> prerequisite-patch-id: c3311a175dacc8d31ac8143f6deb36a1a46bd960
> prerequisite-patch-id: e2348c7f5cdad006aeb10ddda81a184859941c8c
> prerequisite-patch-id: 54003bdf23d570ce671626496a6622319a4ee2c8
> --
> 2.43.0

Thank you for the patch

Regards
- Jayatheerth



There are no updates to t/t1900-repo-info.sh.
Since path normalization can be quite tricky across
different OS environments, we absolutely need tests to
verify how path.git-dir and path.common-dir behave
under both --path-format=absolute and --path-format=relative.

For example
In both patches, if the path returns NULL, you return an error(...).
Have you tested how this behaves if a user runs git repo info --all

This is one I could think of...


> These mirror the information available through
> `git rev-parse --git-dir` and `git rev-parse --common-dir`,
> respectively.
>
> This series builds on the recent path-related changes to
> `git repo info` (including `path.toplevel` and the
> `--path-format` flag), which are currently under review.
>
> Both fields respect the `--path-format` semantics introduced
> there.
>

The new keys haven't been added to Documentation/git-repo.adoc.


> Pushkar Singh (2):
>   repo: add the field path.git-dir
>   repo: add the field path.common-dir
>
>  builtin/repo.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
>
> base-commit: 625c4fb2daac9879b299dd1cae2e793d2821dec0
> prerequisite-patch-id: a15d35d8ce98f550953b8d2b5766b945ae73013e
> prerequisite-patch-id: c3311a175dacc8d31ac8143f6deb36a1a46bd960
> prerequisite-patch-id: e2348c7f5cdad006aeb10ddda81a184859941c8c
> prerequisite-patch-id: 54003bdf23d570ce671626496a6622319a4ee2c8
> --
> 2.43.0

Thank you for the patch

Regards
- Jayatheerth