public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
To: jayatheerthkulkarni2005@gmail.com
Cc: git@vger.kernel.org
Subject: [PATCH v3 2/3] path: use size_t for dir_prefix length
Date: Thu,  5 Mar 2026 18:23:31 +0530	[thread overview]
Message-ID: <20260305125332.27600-3-jayatheerthkulkarni2005@gmail.com> (raw)
In-Reply-To: <20260305125332.27600-1-jayatheerthkulkarni2005@gmail.com>

The strlen() function returns a size_t. Storing this in a standard
signed int is a bad practice that invites overflow vulnerabilities if
paths get absurdly long.

Switch the variable to size_t. This is safe to do because 'len' is
strictly used as an argument to strncmp() (which expects size_t) and
as a positive array index, involving no signed arithmetic that could
rely on negative values.

Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
---
 path.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/path.c b/path.c
index f613d8bbd1..56be5e1726 100644
--- a/path.c
+++ b/path.c
@@ -58,7 +58,7 @@ static void strbuf_cleanup_path(struct strbuf *sb)
 
 static int dir_prefix(const char *buf, const char *dir)
 {
-	int len = strlen(dir);
+	size_t len = strlen(dir);
 	return !strncmp(buf, dir, len) &&
 		(is_dir_sep(buf[len]) || buf[len] == '\0');
 }
-- 
2.53.0


  parent reply	other threads:[~2026-03-05 12:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 14:21 [PATCH 0/3] path: clean up few things K Jayatheerth
2026-03-02 14:21 ` [PATCH 1/3] path: remove unused header K Jayatheerth
2026-03-02 14:21 ` [PATCH 2/3] path: use the right datatype K Jayatheerth
2026-03-03 13:42   ` Patrick Steinhardt
2026-03-03 16:21   ` Junio C Hamano
2026-03-02 14:21 ` [PATCH 3/3] path: remove redundant function calls K Jayatheerth
2026-03-03 13:42   ` Patrick Steinhardt
2026-03-03 16:39   ` Junio C Hamano
2026-03-04 13:04 ` [PATCH v2 0/3] clean up a few things K Jayatheerth
2026-03-04 13:05   ` [PATCH v2 1/3] path: remove unused header K Jayatheerth
2026-03-04 13:05   ` [PATCH v2 2/3] path: use size_t for dir_prefix length K Jayatheerth
2026-03-04 17:15     ` Junio C Hamano
2026-03-04 13:05   ` [PATCH v2 3/3] path: remove redundant function calls K Jayatheerth
2026-03-05 12:53   ` [PATCH v3 0/3] clean up a few things K Jayatheerth
2026-03-05 12:53     ` [PATCH v3 1/3] path: remove unused header K Jayatheerth
2026-03-05 12:53     ` K Jayatheerth [this message]
2026-03-05 12:53     ` [PATCH v3 3/3] path: remove redundant function calls K Jayatheerth
2026-03-05 19:36     ` [PATCH v3 0/3] clean up a few things Junio C Hamano
2026-03-06  1:47       ` K Jayatheerth
2026-03-06  1:59       ` K Jayatheerth
2026-03-06 21:58         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260305125332.27600-3-jayatheerthkulkarni2005@gmail.com \
    --to=jayatheerthkulkarni2005@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox