public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Pablo Sabater <pabloosabaterr@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Pablo Sabater <pabloosabaterr@gmail.com>
Subject: [GSoC PATCH v2] t9200: replace test -f/-d with modern path helpers
Date: Mon,  9 Mar 2026 17:28:32 +0100	[thread overview]
Message-ID: <20260309162832.605969-1-pabloosabaterr@gmail.com> (raw)
In-Reply-To: <20260309150935.578465-1-pabloosabaterr@gmail.com>

Replace old style 'test -f' and 'test -d' with modern helpers
'test_path_is_file' and 'test_path_is_dir' respectively.

The instances were found with:

	git grep "test -[efd]" t/

Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com>
---
 t/t9200-git-cvsexportcommit.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
index a44eabf0d8..4507e8e6db 100755
--- a/t/t9200-git-cvsexportcommit.sh
+++ b/t/t9200-git-cvsexportcommit.sh
@@ -31,7 +31,7 @@ export CVSROOT CVSWORK GIT_DIR
 rm -rf "$CVSROOT" "$CVSWORK"
 
 cvs init &&
-test -d "$CVSROOT" &&
+test_path_is_dir "$CVSROOT" &&
 cvs -Q co -d "$CVSWORK" . &&
 echo >empty &&
 git add empty &&
@@ -303,7 +303,7 @@ test_expect_success 're-commit a removed filename which remains in CVS attic' '
 	git commit -m "Added attic_gremlin" &&
 	git cvsexportcommit -w "$CVSWORK" -c HEAD &&
 	(cd "$CVSWORK" && cvs -Q update -d) &&
-	test -f "$CVSWORK/attic_gremlin"
+	test_path_is_file "$CVSWORK/attic_gremlin"
 '
 
 # the state of the CVS sandbox may be indeterminate for ' space'
-- 
2.43.0


  parent reply	other threads:[~2026-03-09 16:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 15:09 [GSoC PATCH] t9200: use helpers to replace test -f <path> and test -d <path> Pablo Sabater
2026-03-09 15:20 ` Junio C Hamano
2026-03-09 15:39   ` Pablo
2026-03-09 16:28 ` Pablo Sabater [this message]
2026-03-09 21:03   ` [GSoC PATCH v2] t9200: replace test -f/-d with modern path helpers Junio C Hamano
2026-03-09 22:54     ` Pablo
2026-03-09 23:01 ` [GSoC PATCH v3] " Pablo Sabater
2026-03-09 23:26   ` Junio C Hamano
2026-03-11 10:59   ` Pablo
2026-03-11 17:52   ` Junio C Hamano
2026-03-11 19:06     ` Pablo
2026-03-11 19:42       ` Junio C Hamano
2026-03-11 19:49         ` Pablo
2026-03-11 20:31           ` Junio C Hamano
2026-03-12 17:33 ` [GSoC PATCH v4] t9200: replace test -f with modern path helper Pablo Sabater
2026-03-12 17:37   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309162832.605969-1-pabloosabaterr@gmail.com \
    --to=pabloosabaterr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox