From: Jeff King <peff@peff.net>
To: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, jonathantanmy@google.com,
christian.couder@gmail.com, karthik.188@gmail.com
Subject: Re: [PATCH] t0410: modernize delete_object helper
Date: Thu, 12 Mar 2026 16:33:37 -0400 [thread overview]
Message-ID: <20260312203337.GA2552877@coredump.intra.peff.net> (raw)
In-Reply-To: <20260312125030.7799-1-r.siddharth.shrimali@gmail.com>
On Thu, Mar 12, 2026 at 06:20:30PM +0530, Siddharth Shrimali wrote:
> delete_object () {
> - rm $1/.git/objects/$(echo $2 | sed -e 's|^..|&/|')
> + repo=$1
> + obj=$2
> + path="$repo/.git/objects/$(test_oid_to_path $obj)" &&
> + test_path_is_file "$path" &&
> + rm "$path"
> }
It might worth marking these new variables with "local". They are not
used elsewhere by the script currently, but they are common enough names
that a collision in the future doesn't seem that unlikely.
-Peff
next prev parent reply other threads:[~2026-03-12 20:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 12:50 [PATCH] t0410: modernize delete_object helper Siddharth Shrimali
2026-03-12 14:17 ` Pushkar Singh
2026-03-12 19:05 ` Eric Sunshine
2026-03-12 19:09 ` Junio C Hamano
2026-03-12 20:33 ` Jeff King [this message]
2026-03-12 22:03 ` Junio C Hamano
2026-03-13 2:58 ` [PATCH v2] " Siddharth Shrimali
2026-03-13 4:58 ` Jeff King
2026-03-13 15:29 ` Junio C Hamano
2026-03-18 2:37 ` Jeff King
2026-03-13 5:31 ` [PATCH v3] " Siddharth Shrimali
2026-03-13 15:20 ` Junio C Hamano
2026-03-13 15:19 ` [PATCH v2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312203337.GA2552877@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=karthik.188@gmail.com \
--cc=r.siddharth.shrimali@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox