* [PATCH GSOC] Signed-off-by: aum2357 <ahambrahmasmi2357@gmail.com>
@ 2026-03-13 14:02 aum2357
0 siblings, 0 replies; 3+ messages in thread
From: aum2357 @ 2026-03-13 14:02 UTC (permalink / raw)
To: git; +Cc: aum2357
diff: use conventional comparison order
Replace `0 <= addremove_explicit` with `addremove_explicit >= 0`
to follow the common coding style where variables appear on the
left side of comparisons.
---
builtin/add.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/add.c b/builtin/add.c
index 0ee21692c2..ad0d6047af 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -432,7 +432,7 @@ int cmd_add(int argc,
argc--;
argv++;
- if (0 <= addremove_explicit)
+ if ( addremove_explicit >= 0 )
addremove = addremove_explicit;
else if (take_worktree_changes && ADDREMOVE_DEFAULT)
addremove = 0; /* "-u" was given but not "-A" */
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH GSOC] Signed-off-by: aum2357 <ahambrahmasmi2357@gmail.com>
@ 2026-03-13 14:00 aum2357
0 siblings, 0 replies; 3+ messages in thread
From: aum2357 @ 2026-03-13 14:00 UTC (permalink / raw)
To: git; +Cc: aum2357
diff: use conventional comparison order
Replace `0 <= addremove_explicit` with `addremove_explicit >= 0`
to follow the common coding style where variables appear on the
left side of comparisons.
---
builtin/add.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/add.c b/builtin/add.c
index 0ee21692c2..ad0d6047af 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -432,7 +432,7 @@ int cmd_add(int argc,
argc--;
argv++;
- if (0 <= addremove_explicit)
+ if ( addremove_explicit >= 0 )
addremove = addremove_explicit;
else if (take_worktree_changes && ADDREMOVE_DEFAULT)
addremove = 0; /* "-u" was given but not "-A" */
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH GSOC] Signed-off-by: aum2357 <ahambrahmasmi2357@gmail.com>
@ 2026-03-13 14:00 aum2357
0 siblings, 0 replies; 3+ messages in thread
From: aum2357 @ 2026-03-13 14:00 UTC (permalink / raw)
To: git; +Cc: aum2357
diff: use conventional comparison order
Replace `0 <= addremove_explicit` with `addremove_explicit >= 0`
to follow the common coding style where variables appear on the
left side of comparisons.
---
builtin/add.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/add.c b/builtin/add.c
index 0ee21692c2..ad0d6047af 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -432,7 +432,7 @@ int cmd_add(int argc,
argc--;
argv++;
- if (0 <= addremove_explicit)
+ if ( addremove_explicit >= 0 )
addremove = addremove_explicit;
else if (take_worktree_changes && ADDREMOVE_DEFAULT)
addremove = 0; /* "-u" was given but not "-A" */
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-13 14:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 14:02 [PATCH GSOC] Signed-off-by: aum2357 <ahambrahmasmi2357@gmail.com> aum2357
-- strict thread matches above, loose matches on Subject: below --
2026-03-13 14:00 aum2357
2026-03-13 14:00 aum2357
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox