From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] rev-parse: have --parseopt callers exit 0 on --help
Date: Tue, 17 Mar 2026 21:22:14 -0400 [thread overview]
Message-ID: <20260318012214.GC720335@coredump.intra.peff.net> (raw)
In-Reply-To: <abnwxmoOw-ZLT858@fruit.crustytoothpaste.net>
On Wed, Mar 18, 2026 at 12:24:38AM +0000, brian m. carlson wrote:
> None of these seem like they're likely to care about the exit status and
> I suspect that if they do, they are probably using `|| true` to ignore
> the unexpected 129 exit code.
Yeah, I'd venture to say that moving from 129 to 0 would be a strict
improvement for the cases you outlined.
> So I agree that there's unlikely to be any sort of backward
> compatibility issues. If the consensus is that this is shipped only in
> 3.0, then we can do that, but I think many people are not going to care
> and those that do will welcome the change, so I'd just rather treat it
> as a bug that we fix.
Nah, I think everything I have seen points to treating this as a simple
improvement / fix that we can do in the regular way.
-Peff
next prev parent reply other threads:[~2026-03-18 1:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 0:52 Unexpected exit code for --help with rev-parse --parseopt brian m. carlson
2026-03-15 3:14 ` Jeff King
2026-03-15 16:59 ` brian m. carlson
2026-03-15 18:16 ` Jeff King
2026-03-16 22:07 ` [PATCH] rev-parse: have --parseopt callers exit 0 on --help brian m. carlson
2026-03-17 0:47 ` Junio C Hamano
2026-03-17 11:59 ` brian m. carlson
2026-03-17 14:55 ` Jeff King
2026-03-17 15:07 ` Jeff King
2026-03-17 17:06 ` Junio C Hamano
2026-03-17 18:44 ` Jeff King
2026-03-18 0:24 ` brian m. carlson
2026-03-18 1:22 ` Jeff King [this message]
2026-03-18 2:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318012214.GC720335@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox