From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>,
git@vger.kernel.org, sunshine@sunshineco.com,
pushkarkumarsingh1970@gmail.com, christian.couder@gmail.com,
karthik.188@gmail.com
Subject: Re: [PATCH v2] t0410: modernize delete_object helper
Date: Tue, 17 Mar 2026 22:37:57 -0400 [thread overview]
Message-ID: <20260318023757.GA1925517@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq3423928q.fsf@gitster.g>
On Fri, Mar 13, 2026 at 08:29:41AM -0700, Junio C Hamano wrote:
> I am tempted to add this to SubmittingPatches::[test]; the first
> line of the new paragraph appears several lines before the pre-
> context but without "`make test` from the top-level".
> [...]
> +After any code change, make sure that the entire test suite passes,
> +with `make test` from the top-level. We say this twice here because
> +it is important.
Seems reasonable. The other mention of "run the whole suite" is buried
inside a big paragraph.
I have no idea if people read the document at all, though. I certainly
don't, but I am also not a new person trying to join the project. I've
usually read, if not participated in, most discussions which lead to
changes in them anyway. ;)
-Peff
next prev parent reply other threads:[~2026-03-18 2:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 12:50 [PATCH] t0410: modernize delete_object helper Siddharth Shrimali
2026-03-12 14:17 ` Pushkar Singh
2026-03-12 19:05 ` Eric Sunshine
2026-03-12 19:09 ` Junio C Hamano
2026-03-12 20:33 ` Jeff King
2026-03-12 22:03 ` Junio C Hamano
2026-03-13 2:58 ` [PATCH v2] " Siddharth Shrimali
2026-03-13 4:58 ` Jeff King
2026-03-13 15:29 ` Junio C Hamano
2026-03-18 2:37 ` Jeff King [this message]
2026-03-13 5:31 ` [PATCH v3] " Siddharth Shrimali
2026-03-13 15:20 ` Junio C Hamano
2026-03-13 15:19 ` [PATCH v2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318023757.GA1925517@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=pushkarkumarsingh1970@gmail.com \
--cc=r.siddharth.shrimali@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox