From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>,
git@vger.kernel.org, joliss42@gmail.com, joliss@gmail.com
Subject: Re: [PATCH v3 1/2] refspec: safely parse refspecs outside a repository
Date: Mon, 23 Mar 2026 19:10:49 -0400 [thread overview]
Message-ID: <20260323231049.GA23721@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq341q41wu.fsf@gitster.g>
On Mon, Mar 23, 2026 at 03:27:29PM -0700, Junio C Hamano wrote:
> Looking good. Shall we declare victory and mark the topic for
> 'next' by now?
I'm not entirely convinced the better solution isn't just:
diff --git a/remote-curl.c b/remote-curl.c
index 92e40bb682..60774af929 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -1552,6 +1552,11 @@ int cmd_main(int argc, const char **argv)
goto cleanup;
}
+ /* yuck, see 9e89dcb66a (builtin/ls-remote: fall back to SHA1 outside
+ * of a repo, 2024-08-02) */
+ if (nongit)
+ repo_set_hash_algo(the_repository, GIT_HASH_DEFAULT);
+
options.verbosity = 1;
options.progress = !!isatty(2);
options.thin = 1;
That would make the http transport consistent with non-http ones (or at
least any that execute in-process within ls-remote).
Or alternatively, if we think that this use of parse_refspec() is the
only remaining spot for which ls-remote needs a fallback, then we could
apply the patch here and then revert 9e89dcb66a.
-Peff
next prev parent reply other threads:[~2026-03-23 23:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 19:11 remote-curl: segfault parsing remote.<name>.fetch outside a repository Jo Liss
2026-03-21 19:46 ` [PATCH] remote-curl: set fallback hash algorithm outside repo K Jayatheerth
2026-03-21 23:09 ` brian m. carlson
2026-03-22 2:35 ` [PATCH v2] refspec: safely parse refspecs outside a repository K Jayatheerth
2026-03-22 3:31 ` Junio C Hamano
2026-03-22 3:53 ` Jeff King
2026-03-22 5:36 ` [PATCH v3 1/2] " K Jayatheerth
2026-03-22 5:36 ` [PATCH v3 2/2] refspec: fix typo in comment K Jayatheerth
2026-03-23 22:27 ` [PATCH v3 1/2] refspec: safely parse refspecs outside a repository Junio C Hamano
2026-03-23 23:10 ` Jeff King [this message]
2026-03-23 23:39 ` Junio C Hamano
2026-03-24 1:57 ` [PATCH v4 1/2] remote-curl: fall back to default hash outside repo K Jayatheerth
2026-03-24 1:57 ` [PATCH v4 2/2] refspec: fix typo in comment K Jayatheerth
2026-03-24 4:25 ` [PATCH v4 1/2] remote-curl: fall back to default hash outside repo Junio C Hamano
2026-03-21 21:06 ` remote-curl: segfault parsing remote.<name>.fetch outside a repository Jeff King
2026-03-22 1:20 ` Junio C Hamano
2026-03-22 1:37 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323231049.GA23721@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jayatheerthkulkarni2005@gmail.com \
--cc=joliss42@gmail.com \
--cc=joliss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox