From: jayesh0104 <jayeshdaga99@gmail.com>
To: git@vger.kernel.org
Cc: gitgitgadget@gmail.com, a3205153416@gmail.com, jayeshdaga99@gmail.com
Subject: [PATCH v2] t/pack-refs-tests: drop '-f' from test_path_is_missing
Date: Tue, 24 Mar 2026 04:19:03 +0000 [thread overview]
Message-ID: <20260324041903.43155-1-jayeshdaga99@gmail.com> (raw)
In-Reply-To: <a26599ba-01b0-4587-ba0c-bd28a822c615@gmail.com>
test_path_is_missing expects exactly one argument: the path to
check for absence. Passing '-f' is incorrect and results in
"bug in the test script: 1 param" during test execution.
The '-f' flag appears to have been carried over from the
equivalent 'test -f' usage, but test_path_is_missing does not
accept such flags.
Remove the extraneous '-f' to use the helper correctly and
restore proper test behavior.
v2:
- Fix unintended removal of shebang and test framework lines
- Keep file mode unchanged
Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
---
t/pack-refs-tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/pack-refs-tests.sh b/t/pack-refs-tests.sh
index 2fdaccb6c7..4a85d96c6b 100644
--- a/t/pack-refs-tests.sh
+++ b/t/pack-refs-tests.sh
@@ -61,7 +61,7 @@ test_expect_success 'see if a branch still exists after git ${pack_refs} --prune
test_expect_success 'see if git ${pack_refs} --prune remove ref files' '
git branch f &&
git ${pack_refs} --all --prune &&
- ! test -f .git/refs/heads/f
+ test_path_is_missing .git/refs/heads/f
'
test_expect_success 'see if git ${pack_refs} --prune removes empty dirs' '
--
2.43.0
next prev parent reply other threads:[~2026-03-24 4:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 13:50 [PATCH] t/pack-refs-tests: drop '-f' from test_path_is_missing Jayesh Daga via GitGitGadget
2026-03-22 14:27 ` K Jayatheerth
2026-03-22 16:37 ` Tian Yuchen
2026-03-24 4:11 ` jayesh0104
2026-03-24 4:19 ` jayesh0104 [this message]
2026-03-24 4:27 ` [PATCH v2] " Eric Sunshine
2026-03-24 4:46 ` [PATCH v3] t/pack-refs-tests: use test_path_is_missing jayesh0104
2026-03-24 13:43 ` Junio C Hamano
2026-03-24 16:12 ` [PATCH v4] " Jayesh Daga
2026-03-25 17:19 ` Tian Yuchen
2026-03-25 17:44 ` [PATCH v5] tests: use test_path_is_missing instead of '! test -f' Jayesh Daga
2026-03-25 19:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324041903.43155-1-jayeshdaga99@gmail.com \
--to=jayeshdaga99@gmail.com \
--cc=a3205153416@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox