public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Jayesh Daga <jayeshdaga99@gmail.com>
To: a3205153416@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com, jayeshdaga99@gmail.com
Subject: [PATCH v5] tests: use test_path_is_missing instead of '! test -f'
Date: Wed, 25 Mar 2026 17:44:33 +0000	[thread overview]
Message-ID: <20260325174431.73101-4-jayeshdaga99@gmail.com> (raw)
In-Reply-To: <8dcc9e74-80a9-4963-aa9b-56f28e5edf45@gmail.com>

Replace a raw '! test -f' check with test_path_is_missing.

The test_path_is_missing helper integrates with Git’s test
framework and produces clearer failure output. In contrast,
a plain shell '! test -f' check only reports a generic failure
status, which makes it harder to understand whether the file
unexpectedly exists or if another issue caused the test to fail.

It also avoids relying on negated shell conditions, making the
test easier to read and understand.

Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
---
v5:
- Clarify rationale for using test helper
- Explain diagnostic improvement and negation issues
- Address review comments on vague wording

v4:
- Correct commit message to match actual change
- Improve rationale (diagnostics, consistency)
- Move version notes below '---'
- Fix author name to match sign-off

v3:
- Fix commit message wording
---
 t/pack-refs-tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/pack-refs-tests.sh b/t/pack-refs-tests.sh
index 2fdaccb6c7..4a85d96c6b 100644
--- a/t/pack-refs-tests.sh
+++ b/t/pack-refs-tests.sh
@@ -61,7 +61,7 @@ test_expect_success 'see if a branch still exists after git ${pack_refs} --prune
 test_expect_success 'see if git ${pack_refs} --prune remove ref files' '
 	git branch f &&
 	git ${pack_refs} --all --prune &&
-	! test -f .git/refs/heads/f
+	test_path_is_missing .git/refs/heads/f
 '
 
 test_expect_success 'see if git ${pack_refs} --prune removes empty dirs' '
-- 
2.43.0


  reply	other threads:[~2026-03-25 17:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-22 13:50 [PATCH] t/pack-refs-tests: drop '-f' from test_path_is_missing Jayesh Daga via GitGitGadget
2026-03-22 14:27 ` K Jayatheerth
2026-03-22 16:37 ` Tian Yuchen
2026-03-24  4:11   ` jayesh0104
2026-03-24  4:19   ` [PATCH v2] " jayesh0104
2026-03-24  4:27     ` Eric Sunshine
2026-03-24  4:46   ` [PATCH v3] t/pack-refs-tests: use test_path_is_missing jayesh0104
2026-03-24 13:43     ` Junio C Hamano
2026-03-24 16:12       ` [PATCH v4] " Jayesh Daga
2026-03-25 17:19         ` Tian Yuchen
2026-03-25 17:44           ` Jayesh Daga [this message]
2026-03-25 19:27             ` [PATCH v5] tests: use test_path_is_missing instead of '! test -f' Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325174431.73101-4-jayeshdaga99@gmail.com \
    --to=jayeshdaga99@gmail.com \
    --cc=a3205153416@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox