public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Wesley Schwengle <wesleys@opperschaap.net>
Cc: git@vger.kernel.org, "Christian Couder" <chriscool@tuxfamily.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Bence Ferdinandy" <bence@ferdinandy.com>
Subject: Re: [PATCH 3/3] connect: Add support for per-remote and per-namespace SSH options
Date: Fri, 27 Mar 2026 17:45:59 -0400	[thread overview]
Message-ID: <20260327214559.GA599365@coredump.intra.peff.net> (raw)
In-Reply-To: <20260326233739.2911354-4-wesleys@opperschaap.net>

On Thu, Mar 26, 2026 at 07:37:38PM -0400, Wesley Schwengle wrote:

> The following configuration is supported, in order of precedence:
> 
>   1. `remote.<name>.sshIdentityFile' and `remote.<name>.sshOpts'
> 
>   2. `core.sshIdentityFile.<owner>' and `core.sshOpts.<owner>'
> 
>      Where <owner> is derived from the repository path. Nested groups
>      aren't supported: git@host:owner/repo.git becomes "owner",
>      git@host:owner/group/repo.git also becomes "owner".

We already have some conditional config mechanisms, and I don't think
it's a good idea to add one that only works for certain keys. If I
understand correctly, this <owner> feature can already be accomplished
with:

  [includeIf "hasconfig:remote.*.url:**/owner/**"]
  path = all-your-options-for-that-owner

It's a little more verbose (and you have to use a separate file), but it
also allows other conditions, like "gitdir:" for selecting based on how
you lay out your repos locally.

-Peff

  reply	other threads:[~2026-03-27 21:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 23:37 [PATCH 0/3] Add support for per-remote and per-namespace SSH options Wesley Schwengle
2026-03-26 23:37 ` [PATCH 1/3] connect: Rename name to command in connect_git() Wesley Schwengle
2026-03-27 21:33   ` Jeff King
2026-03-28  0:58     ` Wesley
2026-03-28  1:44       ` Jeff King
2026-03-28  2:01         ` Wesley
2026-03-26 23:37 ` [PATCH 2/3] connect: Add transport->remote->name to git_connect() Wesley Schwengle
2026-03-27 21:39   ` Jeff King
2026-03-26 23:37 ` [PATCH 3/3] connect: Add support for per-remote and per-namespace SSH options Wesley Schwengle
2026-03-27 21:45   ` Jeff King [this message]
2026-03-28  0:43     ` Wesley
2026-03-28  2:03       ` Jeff King
2026-03-28  2:25         ` Wesley
2026-03-27  7:51 ` [PATCH 0/3] " Johannes Sixt
2026-03-27 15:04   ` Wesley
2026-03-27 16:10   ` Junio C Hamano
2026-03-27 16:49     ` Wesley
2026-03-27 22:06       ` brian m. carlson
2026-03-28  1:02         ` Wesley
2026-03-28  7:46       ` Johannes Sixt
2026-03-27 21:51     ` brian m. carlson
2026-03-27 22:25       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260327214559.GA599365@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=avarab@gmail.com \
    --cc=bence@ferdinandy.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=wesleys@opperschaap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox