From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: git@vger.kernel.org
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: [PATCH] t6112: avoid tilde expansion
Date: Sat, 18 Apr 2026 18:32:36 +0200 [thread overview]
Message-ID: <20260418163236.2382826-1-szeder.dev@gmail.com> (raw)
e987df5fe6 (list-objects-filter: implement composite filters,
2019-06-27) introduced a test to "t6112-rev-list-filters-objects.sh"
that checks the output of a Git command with the following commands:
grep ~$omitted_1 actual &&
grep ~$omitted_2 actual &&
grep ~$omitted_3 actual &&
Since the leading tilde in the pattern is not quoted/escaped, it is
subject to tilde expansion. So if the system has a user whose
username happens to be equal to the content of one of those
"$omitted_*" variables, then "grep" would look for the user's home
directory. Luckily, those variables contain object hashes, so this is
not very likely.
Furthermore, Bash versions v5.0 and earlier seem to be buggy and don't
handle this particular tilde expansion very well, and either segfault
right away or, in case of v3.2, get stuck in an endless loop and
segfault upon receiving ctrl-c.
Quote those words starting with a tilde to avoid these issues.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
t/t6112-rev-list-filters-objects.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t6112-rev-list-filters-objects.sh b/t/t6112-rev-list-filters-objects.sh
index 39211ef989..e0a825bccf 100755
--- a/t/t6112-rev-list-filters-objects.sh
+++ b/t/t6112-rev-list-filters-objects.sh
@@ -623,9 +623,9 @@ test_expect_success 'verify collecting omits in combined: filter' '
omitted_2=$(echo a | git hash-object --stdin) &&
omitted_3=$(echo abcde | git hash-object --stdin) &&
- grep ~$omitted_1 actual &&
- grep ~$omitted_2 actual &&
- grep ~$omitted_3 actual &&
+ grep "~$omitted_1" actual &&
+ grep "~$omitted_2" actual &&
+ grep "~$omitted_3" actual &&
test_line_count = 3 actual
'
--
2.54.0.rc2.650.gc37764ecfc
next reply other threads:[~2026-04-18 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 16:32 SZEDER Gábor [this message]
2026-04-19 1:26 ` [PATCH] t6112: avoid tilde expansion Elijah Newren
2026-04-20 20:52 ` SZEDER Gábor
2026-04-21 19:21 ` [PATCH v2] " SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260418163236.2382826-1-szeder.dev@gmail.com \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox