From: Jeff King <peff@peff.net>
To: Jonatan Holmgren <jonatan@jontes.page>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, rsch@web.de, michael.grossfeld@amd.com
Subject: Re: [PATCH] alias: restore support for simple dotted aliases
Date: Sun, 26 Apr 2026 19:01:25 -0400 [thread overview]
Message-ID: <20260426230125.GA218434@coredump.intra.peff.net> (raw)
In-Reply-To: <4a130a23-fa32-460b-a338-409d85d18166@jontes.page>
On Sun, Apr 26, 2026 at 09:21:52PM +0200, Jonatan Holmgren wrote:
> I see the appeal of the overlapping-namespace approach for maximum compat.
>
> My hesitation is that it introduces a config model where a single key
> (`alias.foo.bar`) no longer has a clear interpretation, but instead is
> implicitly treated as both a historical alias and structured data. That
> feels harder to reason about and document.
>
> For the regression, I would lean toward a narrower compatibility rule:
> restore dotted aliases except where they collide with explicitly
> recognized structured keys (currently `command`). That keeps behavior
> predictable while still fixing the breakage.
Yeah, I agree with you here (and the rest of this email). My earlier
message was mostly about laying out the possible alternatives.
> One question: do we consider the historical dotted aliases something we
> want to preserve indefinitely, or just something to transition away from?
> My assumption has been that they were an accidental side-effect of the
> config parsing rather than a designed feature, but I agree they are now
> part of existing workflows and need to be handled carefully.
I think it would be OK to consider them a historical curiosity that may
eventually be removed, but without an active deprecation timeline. If
you do not need to work with older versions of Git it is already a good
idea to move to the new syntax because it prevents your alias being
caught up if further keys are added. It might be reasonable for the
documentation to note that (and of course also mention the downside,
which is that older versions of Git will not respect your alias).
We could eventually drop support, but I think it would have to be
either:
1. In some distant version such that "pre-2.54" is considered ancient.
2. At some version boundary where we declare a number of breaking
changes. Git 3.0 is probably going to such a version, but I don't
know if we have a concrete timeline (or how long we'd want a
change to be in the "breaking changes" list in the build-up to that
version).
There's a related question, too, about whether "alias.foo" (without
extra dots) could/should be dropped eventually. I don't see a particular
reason to do so, as the cost to carrying support is quite minimal.
-Peff
next prev parent reply other threads:[~2026-04-26 23:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 18:19 Bug: Hierarchical Aliases no longer work in 2.54.0 Grossfeld, Michael
2026-04-23 21:12 ` Jeff King
2026-04-23 22:55 ` Michael Grossfeld
2026-04-23 21:36 ` René Scharfe
2026-04-23 22:46 ` Michael Grossfeld
2026-04-24 7:29 ` Jonatan Holmgren
2026-04-24 15:10 ` [PATCH] alias: restore support for simple dotted aliases Jonatan Holmgren
2026-04-24 16:09 ` Kristoffer Haugsbakk
2026-04-24 22:47 ` Junio C Hamano
2026-04-25 9:57 ` Jonatan Holmgren
2026-04-25 23:29 ` Jeff King
2026-04-25 23:47 ` Jeff King
2026-04-26 19:21 ` Jonatan Holmgren
2026-04-26 23:01 ` Jeff King [this message]
2026-04-27 8:36 ` Jonatan Holmgren
2026-05-12 4:43 ` Junio C Hamano
2026-04-24 16:17 ` Jonatan Holmgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260426230125.GA218434@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonatan@jontes.page \
--cc=michael.grossfeld@amd.com \
--cc=rsch@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox