Re: [PATCH v3 00/16] repack: incremental MIDX/bitmap-based repacking

[Jeff King <peff@peff.net>]

On Wed, Apr 29, 2026 at 08:13:04PM -0400, Taylor Blau wrote:

> I expect that this should be the final reroll absent any late-breaking
> feedback. The only changes since last time are the following:
> 
>  - Various stale references to "--checksum-only" have been eradicated
>    from commit message(s).
> 
>  - `repack_prepare_midx_command()` now uses `pipe_command()` to
>    eliminate the possibility of a deadlock.
> 
>  - `write_midx_included_packs()` now cleans up after itself properly
>    when receiving multiple lines of output.
> 
>  - The errant test in t7705 was moved to the final commit (where it
>    belongs) instead of the penultimate one.

Thanks, the new pipe_command() and leak-fix for patch 14 look good to
me.

> As usual, a range-diff is included below as well for convenience. Thanks
> in advance for reviewing!

Something funny going on here:

> Range-diff against v2:
>  -:  ----------- >  1:  d6c27317c25 midx-write: handle noop writes when converting incremental chains
>  -:  ----------- >  2:  629c8d23116 midx: use `strset` for retained MIDX files
>  -:  ----------- >  3:  e303bf6a4ac midx: build `keep_hashes` array in order
>  -:  ----------- >  4:  42d76c70060 midx: use `strvec` for `keep_hashes`
>  -:  ----------- >  5:  2c80aa34fac midx: introduce `--no-write-chain-file` for incremental MIDX writes
>  7:  d9acef1334a !  6:  2a05f4b86f3 repack: allow `--write-midx=incremental` without `--geometric`
>     @@ Metadata
>      Author: Taylor Blau <me@ttaylorr.com>
>      
>       ## Commit message ##
>     -    repack: allow `--write-midx=incremental` without `--geometric`
>     +    midx: support custom `--base` for incremental MIDX writes
> [...gigantic range-diff for this commit...]

I'm not sure what's happening here. The 6th patch in v2 was "midx:
support custom --base...". The series you sent looks right, I think, but
maybe your range-diff endpoints were wrong or something?

-Peff