From: Jeff King <peff@peff.net>
To: Greg Hurrell <greg@hurrell.net>
Cc: Greg Hurrell <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Gregory Luke Hurrell Stewart <greg.hurrell@datadoghq.com>
Subject: Re: [PATCH] git-jump: pick a mode automatically when invoked without arguments
Date: Fri, 8 May 2026 13:52:40 -0400 [thread overview]
Message-ID: <20260508175240.GA737125@coredump.intra.peff.net> (raw)
In-Reply-To: <c5e0a1fa-f228-41dd-b547-07b0ad6c0964@app.fastmail.com>
On Fri, May 08, 2026 at 04:30:36PM +0200, Greg Hurrell wrote:
> On Fri, May 8, 2026, at 4:13 PM, Jeff King wrote:
> > On Fri, May 08, 2026 at 09:07:34AM +0000, Greg Hurrell via GitGitGadget wrote:
> >
> > I'd be a little worried that it is more confusing to somebody
> > approaching the command for the first time and just runs "git jump" to
> > not see usage or other guidance. But that might be overly paranoid.
>
> Hopefully, they at least read the README before installing it from contrib/
> (although Homebrew recently starting installing it for folks automatically,
> so may not remain true for much longer on macOS...)
Yeah, I'd hope so. And even if it might be more discoverable, I'm not
sure that is more important than being convenient for experienced users.
I guess a config option would be possible, but probably not worth it for
something as trivial as git-jump.
> It's mostly the finger effort of typing it because I generally know exactly
> which mode I want; eg.
OK, that makes sense.
> This is muscle memory for me at this point, because I've had a `git jump`
> alias for this in my dotfiles[^1] for a couple of years. Homebrew
> installing `git-jump` by default a few months ago[^2] broke this, because
> aliases can't shadow builtin commands.
Ah, yeah, that is frustrating. We try to avoid aliases overrides to
prevent confusion, but for an add-on tool like git-jump I think it is
overly cautious. It might be reasonable to limit that protection only to
commands in Git's exec-path, but I haven't thought hard about it. And I
think it should be considered separately from this patch anyway.
So yeah, your patch looks good to me. Thanks.
-Peff
next prev parent reply other threads:[~2026-05-08 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 9:07 [PATCH] git-jump: pick a mode automatically when invoked without arguments Greg Hurrell via GitGitGadget
2026-05-08 14:13 ` Jeff King
2026-05-08 14:30 ` Greg Hurrell
2026-05-08 17:52 ` Jeff King [this message]
2026-05-14 15:40 ` Erik Cervin Edin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508175240.GA737125@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=greg.hurrell@datadoghq.com \
--cc=greg@hurrell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox