Re: [PATCH v3 2/4] approxidate: alias "today" to "now"

[Tuomas Ahola <taahol@utu.fi>]

Junio C Hamano <gitster@pobox.com> wrote:

> Tuomas Ahola <taahol@utu.fi> writes:
> 
> >     Sorry, I don't know if I understood.  Does the patch change the behavior of
> >     that command somehow?  Is there some kind of edge case I missed?
> 
> No, I did not think it was a good idea to carve the behaviour in
> stone that "git log --since=today" behaves as if it were given "git
> log --since=now".  My reaction would have been very different if we
> were deliberatly and explicitly saying "today is synonym for now",
> but the thing is, it is not a designed behaviour but what
> approxidate does for anything it does not understand, e.g.
> 
>     git log --since=decay
>     git log --since=bogus
> 
> all behave as if it were given --since=now.

Thanks for spelling that out.  So, as there is no deliberative
decision behind the current behaviour of "today", the code has
to remain non-committed on that; we are not at liberty to codify
the status quo.  Right?  But perhaps we can find a least common
denominator.  "Today" means the current day (well, obviously),
and this seems to be enough to get "today at noon" and such to work:

```
static void date_today(struct tm *tm, struct tm *now, int *num)
{
	*num = 0;
	tm->tm_mday = now->tm_mday;
}
```

It gets the job done whitout setting in stone too much anything
that is up for debate.  Do you see that could work?

--Tuomas