Re: [PATCH v3 5/8] t7810: turn MB_REGEX check into a lazy prereq

[Jeff King <peff@peff.net>]

On Thu, Jun 04, 2026 at 12:07:35PM +0200, Patrick Steinhardt wrote:

> diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh
> index 1b195bee59..d61c4a4d73 100755
> --- a/t/t7810-grep.sh
> +++ b/t/t7810-grep.sh
> @@ -18,8 +18,9 @@ test_invalid_grep_expression() {
>  	'
>  }
>  
> -LC_ALL=en_US.UTF-8 test-tool regex '^.$' '¿' &&
> -  test_set_prereq MB_REGEX
> +test_lazy_prereq MB_REGEX '
> +	LC_ALL=en_US.UTF-8 test-tool regex "^.$" "¿"
> +'

Oh good. Since the error was coming from the shell, I was worried that
the use of LC_ALL inside the test snippets was somehow causing output to
leak to stderr. But it was just (yet another) case where we ran a tool
outside of a snippet, which is easy to fix.

This also allays my fears that the tests might have been misbehaving on
those other platforms. They are (and were) caught by this prereq and not
run at all, which is the right thing.

Thanks for fixing.

-Peff