From: Jeff King <peff@peff.net>
To: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v3] transport-helper: fix TSAN race in transfer_debug()
Date: Thu, 11 Jun 2026 04:33:20 -0400 [thread overview]
Message-ID: <20260611083320.GI2191159@coredump.intra.peff.net> (raw)
In-Reply-To: <20260609134741.4727-2-pushkarkumarsingh1970@gmail.com>
On Tue, Jun 09, 2026 at 01:47:42PM +0000, Pushkar Singh wrote:
> Changes since v2:
> - Treat an uninitialized transfer_debug_enabled as a BUG()
> instead of silently treating it as disabled.
> - Follow Jeff King's suggestion to distinguish an
> uninitialized state from a disabled state.
Thanks, this looks OK to me.
> + if (transfer_debug_enabled < 0)
> + BUG("somebody forgot to check GIT_TRANSLOOP_DEBUG!");
That is a somewhat silly message, but the point is that nobody is
supposed to see it ever. And it does lead them to roughly the right
spot, so I think it's sufficient. (Yes, I know it came from my earlier
response).
-Peff
prev parent reply other threads:[~2026-06-11 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 20:13 [PATCH] transport-helper: fix TSAN race in transfer_debug() Pushkar Singh
2026-06-04 1:09 ` Junio C Hamano
2026-06-04 10:19 ` Pushkar Singh
2026-06-04 13:23 ` [PATCH v2] " Pushkar Singh
2026-06-09 0:28 ` Jeff King
2026-06-09 13:47 ` [PATCH v3] " Pushkar Singh
2026-06-11 8:33 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260611083320.GI2191159@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pushkarkumarsingh1970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox