Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH 2/2] format-patch: fix leak of rev_info in prepare_bases()
Date: Wed, 1 Jul 2026 04:47:33 -0400	[thread overview]
Message-ID: <20260701084733.GA814472@coredump.intra.peff.net> (raw)
In-Reply-To: <akTS_rPV7JaGHKRq@pks.im>

On Wed, Jul 01, 2026 at 10:42:38AM +0200, Patrick Steinhardt wrote:

> > We already run a special leak job for linux-reftables. Why not turn that
> > job into "leaks plus reftables plus test-vars"? The only downside would
> > be potentially hiding leaks found by linux-reftables-leaks if the
> > test-vars features force us into a difference code path. But looking at
> > the list, it doesn't seem likely to me. None of them is particularly
> > ref-related.
> > 
> > In fact, I kind of wonder if we could fold linux-reftables into the
> > test-vars job completely.
> 
> linux-reftable or linux-reftable-leaks? I think it would certainly make
> sense to drop one of these and merge it into linux-TEST-vars. The
> linux-reftable job doesn't provide any benefit over its -leak variant,
> so that would be the candidate I'd personally merge.

Both. Fold linux-reftable into linux-TEST-vars, and then drop
linux-reftable-leaks in favor of a new linux-TEST-vars-leaks.

-Peff

  reply	other threads:[~2026-07-01  8:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  6:39 [PATCH 0/2] small leak fix in format-patch Jeff King
2026-06-30  6:41 ` [PATCH 1/2] t: move LSan errors from stdout to stderr Jeff King
2026-06-30  6:43 ` [PATCH 2/2] format-patch: fix leak of rev_info in prepare_bases() Jeff King
2026-06-30 10:26   ` Patrick Steinhardt
2026-07-01  8:13     ` Jeff King
2026-07-01  8:42       ` Patrick Steinhardt
2026-07-01  8:47         ` Jeff King [this message]
2026-07-01  9:01           ` Patrick Steinhardt
2026-07-02  8:58             ` Jeff King
2026-07-02 10:08               ` Patrick Steinhardt
2026-07-03 20:45                 ` Junio C Hamano
2026-07-06  0:34                   ` Jeff King
2026-07-06  5:57                     ` Patrick Steinhardt
2026-07-04 21:13 ` [PATCH 0/2] small leak fix in format-patch Karthik Nayak
2026-07-06  0:01   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260701084733.GA814472@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox