Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: "D. Ben Knoble" <ben.knoble+github@gmail.com>,
	git@vger.kernel.org,
	"brian m . carlson" <sandals@crustytoothpaste.net>,
	Junio C Hamano <gitster@pobox.com>,
	Ramsay Jones <ramsay@ramsayjones.plus.com>
Subject: Re: [PATCH] meson: wire up USE_NSEC build knob
Date: Tue, 7 Jul 2026 00:38:50 -0400	[thread overview]
Message-ID: <20260707043850.GC677056@coredump.intra.peff.net> (raw)
In-Reply-To: <aktOn-3K41Uhl9cr@pks.im>

On Mon, Jul 06, 2026 at 08:43:43AM +0200, Patrick Steinhardt wrote:

> > To summarize: If we're all leaning in the direction of a run-time flag
> > instead, I can noodle in that direction. That certainly involves a bit
> > more surgery than just giving Meson access to the option, but the
> > dynamism may be nice. I'm not too sure how we'd write a test case for
> > it, though.
> 
> I don't think we'd necessarily need a way to detect this. Our current
> build default is to have this disabled, so I'd keep it this way, but
> automatically compile nsec-support into Git if available. And then we
> provide a way for users to opt-in to the new behaviour via the config.

Yeah, agreed. Even if we eventually auto-detect, the first step is
adding the config at all. And then we can decide whether to stop there
or not.

I'm agnostic on whether we add USE_NSEC to meson in the meantime, if it
might eventually be ripped out of the Makefile. We _could_ retain
USE_NSEC to change the unconfigured default for a given build, but I'd
be inclined to just remove it entirely once the runtime config is
available.

-Peff

      reply	other threads:[~2026-07-07  4:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-20 16:00 [PATCH] meson: wire up USE_NSEC build knob D. Ben Knoble
2026-06-21  1:01 ` Junio C Hamano
2026-06-21 16:41   ` D. Ben Knoble
2026-06-22  8:13   ` Patrick Steinhardt
2026-06-21 17:49 ` Jeff King
2026-06-22  8:13   ` Patrick Steinhardt
2026-06-28  8:18     ` Jeff King
2026-06-28  8:48       ` Jeff King
2026-06-29  0:23         ` brian m. carlson
2026-06-29  6:08       ` Patrick Steinhardt
2026-06-29 21:38         ` Junio C Hamano
2026-06-30  5:43         ` Jeff King
2026-07-03 15:46           ` D. Ben Knoble
2026-07-03 15:46       ` D. Ben Knoble
2026-07-03 15:46     ` D. Ben Knoble
2026-07-06  6:43       ` Patrick Steinhardt
2026-07-07  4:38         ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260707043850.GC677056@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=ben.knoble+github@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox