From: Marcelo Machado Lage <marcelomlage@usp.br>
To: git@vger.kernel.org
Cc: Marcelo Machado Lage <marcelomlage@usp.br>,
Vinicius Lira de Freitas <vinilira@usp.br>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 1/2] t9811: break long && chains into multiple lines
Date: Sat, 11 Jul 2026 13:04:46 -0300 [thread overview]
Message-ID: <20260711160447.99708-2-marcelomlage@usp.br> (raw)
In-Reply-To: <20260711160447.99708-1-marcelomlage@usp.br>
Rewrite single-line && chains by breaking them into multiple lines.
Co-authored-by: Vinicius Lira de Freitas <vinilira@usp.br>
Signed-off-by: Vinicius Lira de Freitas <vinilira@usp.br>
Signed-off-by: Marcelo Machado Lage <marcelomlage@usp.br>
---
t/t9811-git-p4-label-import.sh | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh
index 7614dfbd95..072bc88210 100755
--- a/t/t9811-git-p4-label-import.sh
+++ b/t/t9811-git-p4-label-import.sh
@@ -64,7 +64,9 @@ test_expect_success 'basic p4 labels' '
git checkout TAG_F1_ONLY &&
! test -f f2 &&
git checkout TAG_WITH\$_SHELL_CHAR &&
- test -f f1 && test -f f2 && test -f file_with_\$metachar &&
+ test -f f1 &&
+ test -f f2 &&
+ test -f file_with_\$metachar &&
git show TAG_LONG_LABEL | grep -q "A Label second line"
)
@@ -231,17 +233,25 @@ test_expect_success 'importing labels with missing revisions' '
P4CLIENT=missing-revision &&
client_view "//depot/missing-revision/... //missing-revision/..." &&
cd "$cli" &&
- >f1 && p4 add f1 && p4 submit -d "start" &&
+ >f1 &&
+ p4 add f1 &&
+ p4 submit -d "start" &&
p4 tag -l TAG_S0 ... &&
- >f2 && p4 add f2 && p4 submit -d "second" &&
+ >f2 &&
+ p4 add f2 &&
+ p4 submit -d "second" &&
startrev=$(p4_head_revision //depot/missing-revision/...) &&
- >f3 && p4 add f3 && p4 submit -d "third" &&
+ >f3 &&
+ p4 add f3 &&
+ p4 submit -d "third" &&
- p4 edit f2 && date >f2 && p4 submit -d "change" f2 &&
+ p4 edit f2 &&
+ date >f2 &&
+ p4 submit -d "change" f2 &&
endrev=$(p4_head_revision //depot/missing-revision/...) &&
--
2.34.1
next prev parent reply other threads:[~2026-07-11 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 14:07 [PATCH] t9811: replace 'test -f' and '! test -f' with 'test_path_*' Marcelo Machado Lage
2026-07-03 8:19 ` Patrick Steinhardt
2026-07-03 20:48 ` Junio C Hamano
2026-07-06 15:00 ` Marcelo Machado Lage
2026-07-07 14:51 ` Patrick Steinhardt
2026-07-11 16:04 ` [PATCH v2 0/2] t9811: reformat and modernize tests Marcelo Machado Lage
2026-07-11 16:04 ` Marcelo Machado Lage [this message]
2026-07-11 16:04 ` [PATCH v2 2/2] t9811: replace 'test -f' and '! test -f' with 'test_path_*' Marcelo Machado Lage
2026-07-13 11:10 ` [PATCH v2 0/2] t9811: reformat and modernize tests Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260711160447.99708-2-marcelomlage@usp.br \
--to=marcelomlage@usp.br \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vinilira@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox