From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Gatla Vishweshwar Reddy <gatlavishweshwarreddy26@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2] show-branch: convert object.flags to commit-slab with uint64_t
Date: Tue, 14 Jul 2026 18:00:42 -0400 [thread overview]
Message-ID: <20260714220042.GC4095533@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqcxwps3ro.fsf@gitster.g>
On Tue, Jul 14, 2026 at 01:41:15PM -0700, Junio C Hamano wrote:
> This limitation is precisely where the concept of using a commit
> slab shines. However, to truly take advantage of a commit slab, the
> slab stride must be variable. If the tool is handling more than 80
> branches, for example, each commit requires a `uint64_t[2]` array
> allocation (since a single `uint64_t` provides only 64 bits, while
> `uint64_t[2]` can store up to 128 bits).
Yep. Going back to the last time this topic came up, I'll just point at:
https://lore.kernel.org/git/20250225011757.GA752084@coredump.intra.peff.net/
which references one of the earliest commit-slab series. Especially the
part that adds arbitrary-sized bitset support, which could be useful
here (patch 4 adds the bitset, patch 6 shows how it is used).
-Peff
next prev parent reply other threads:[~2026-07-14 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 18:30 [PATCH] show-branch: convert object.flags usage to a commit-slab Gatla Vishweshwar Reddy
2026-07-14 20:01 ` [PATCH v2] show-branch: convert object.flags to commit-slab with uint64_t Gatla Vishweshwar Reddy
2026-07-14 20:41 ` Junio C Hamano
2026-07-14 22:00 ` Jeff King [this message]
2026-07-15 1:47 ` [PATCH v3] show-branch: convert per-branch flags to commit-slab Gatla Vishweshwar Reddy
2026-07-15 3:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714220042.GC4095533@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=gatlavishweshwarreddy26@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox