From: Kenneth Lorber <keni@his.com>
To: git@vger.kernel.org
Cc: Kenneth Lorber <keni@his.com>, redoste <redoste@redoste.xyz>,
Fabian Stelzer <fs@gigacodes.de>, Patrick Steinhardt <ps@pks.im>,
Junio C Hamano <gitster@pobox.com>,
Xi Ruoyao <xry111@xry111.site>
Subject: [PATCH 0/1] t7528: fix failure under csh
Date: Sun, 2 Aug 2026 20:41:02 -0400 [thread overview]
Message-ID: <20260803004105.36913-1-keni@his.com> (raw)
The test suite fails at t7528 when run in an account with tcsh as
the login shell due to $SHELL being "/bin/tcsh"; similar behaviour
is expected under other csh-like shells.
From ssh-agent(1):
-s Generate Bourne shell commands on stdout. This is the default
if SHELL does not look like it's a csh style of shell.
This patch explicitly tells ssh-agent to use Bourne shell syntax, thus
removing a spurious test failure for users with csh style shells.
An alternative change would be to have test-lib.sh clear $SHELL; this
was rejected as potentially hiding additional similar errors. There
are no such additional errors evident currently.
No additional tests are added as the error is in the setup for
testing, not an error in git itself.
Kenneth Lorber (1):
t7528: fix failure under csh
t/t7528-signed-commit-ssh.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.43.0
next reply other threads:[~2026-08-03 0:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 0:41 Kenneth Lorber [this message]
2026-08-03 0:41 ` [PATCH 1/1] t7528: fix failure under csh Kenneth Lorber
2026-08-03 2:13 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803004105.36913-1-keni@his.com \
--to=keni@his.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
--cc=redoste@redoste.xyz \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox