From: Christian Couder <christian.couder@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Patrick Steinhardt <ps@pks.im>, Elijah Newren <newren@gmail.com>,
Jeff King <peff@peff.net>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Justin Tobler <jltobler@gmail.com>,
Christian Couder <christian.couder@gmail.com>
Subject: [PATCH v2 05/12] fast-import: use int for some bool flags
Date: Tue, 4 Aug 2026 12:03:48 +0200 [thread overview]
Message-ID: <20260804100355.1299498-6-christian.couder@gmail.com> (raw)
In-Reply-To: <20260804100355.1299498-1-christian.couder@gmail.com>
The `show_stats` and `quiet` flags are meant to be parsed and used as
boolean flags.
To easily parse them using OPT_BOOL in a following commit, let's change
their type from 'unsigned int' to just 'int'.
Signed-off-by: Christian Couder <christian.couder@gmail.com>
---
builtin/fast-import.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/fast-import.c b/builtin/fast-import.c
index 9fc9ebe65a..9c8edd7c89 100644
--- a/builtin/fast-import.c
+++ b/builtin/fast-import.c
@@ -182,8 +182,8 @@ static unsigned long branch_count;
static unsigned long branch_load_count;
static int failure;
static FILE *pack_edges;
-static unsigned int show_stats = 1;
-static unsigned int quiet;
+static int show_stats = 1;
+static int quiet;
static int global_argc;
static const char **global_argv;
static const char *global_prefix;
--
2.55.0.492.g44bba30fd7.dirty
next prev parent reply other threads:[~2026-08-04 10:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 16:55 [PATCH 0/7] fast-import: standardize usage string and SYNOPSIS Christian Couder
2026-07-16 16:55 ` [PATCH 1/7] parse-options: introduce OPT_HIDDEN_GROUP Christian Couder
2026-07-16 21:14 ` Junio C Hamano
2026-07-16 22:14 ` .mailmap etiquette (was "Re: [PATCH 1/7] parse-options: introduce OPT_HIDDEN_GROUP") D. Ben Knoble
2026-07-16 22:31 ` Junio C Hamano
2026-08-03 17:19 ` [PATCH 1/7] parse-options: introduce OPT_HIDDEN_GROUP Christian Couder
2026-07-16 16:55 ` [PATCH 2/7] api-parse-options.adoc: document per-option flags Christian Couder
2026-07-16 16:55 ` [PATCH 3/7] api-parse-options.adoc: document hidden and OPT_*_F option macros Christian Couder
2026-07-16 16:55 ` [PATCH 4/7] fast-import: localize 'i' into the 'for' loops using it Christian Couder
2026-07-16 16:55 ` [PATCH 5/7] fast-import: introduce 'struct fast_import_state' Christian Couder
2026-07-16 16:55 ` [PATCH 6/7] fast-import: move command state globals into " Christian Couder
2026-07-16 16:55 ` [PATCH 7/7] fast-import: use struct option for usage string Christian Couder
2026-07-16 21:35 ` Junio C Hamano
2026-08-03 17:23 ` Christian Couder
2026-08-04 10:03 ` [PATCH v2 00/12] fast-import: standardize usage string and SYNOPSIS Christian Couder
2026-08-04 10:03 ` [PATCH v2 01/12] parse-options: introduce OPT_HIDDEN_GROUP Christian Couder
2026-08-04 10:03 ` [PATCH v2 02/12] api-parse-options.adoc: document per-option flags Christian Couder
2026-08-08 7:25 ` Elijah Newren
2026-08-04 10:03 ` [PATCH v2 03/12] api-parse-options.adoc: document hidden and OPT_*_F option macros Christian Couder
2026-08-04 10:03 ` [PATCH v2 04/12] fast-import: localize 'i' into the 'for' loops using it Christian Couder
2026-08-04 10:03 ` Christian Couder [this message]
2026-08-04 10:03 ` [PATCH v2 06/12] fast-import: factor out option_*() functions Christian Couder
2026-08-04 10:03 ` [PATCH v2 07/12] fast-import: introduce 'struct fast_import_state' Christian Couder
2026-08-08 7:25 ` Elijah Newren
2026-08-04 10:03 ` [PATCH v2 08/12] fast-import: move command state globals into " Christian Couder
2026-08-04 10:03 ` [PATCH v2 09/12] fast-import: use struct option for usage string Christian Couder
2026-08-04 10:03 ` [PATCH v2 10/12] fast-import: use callbacks to parse some options Christian Couder
2026-08-04 10:03 ` [PATCH v2 11/12] fast-import: use parse_options() for command line options Christian Couder
2026-08-08 7:25 ` Elijah Newren
2026-08-04 10:03 ` [PATCH v2 12/12] fast-import: remove useless from_stream argument Christian Couder
2026-08-08 7:26 ` [PATCH v2 00/12] fast-import: standardize usage string and SYNOPSIS Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804100355.1299498-6-christian.couder@gmail.com \
--to=christian.couder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox