Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Colin Hinton <colinlewishinton@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2] chdir-notify.h: Removed unused param 'name'
Date: Sat, 15 Aug 2026 01:12:13 -0400	[thread overview]
Message-ID: <20260815051213.GA26013@coredump.intra.peff.net> (raw)
In-Reply-To: <20260814214210.1625-1-colinlewishinton@gmail.com>

On Fri, Aug 14, 2026 at 02:42:10PM -0700, Colin Hinton wrote:

> The `name` parameter in `chdir_notify_entry` was only ever used by
> chdir_notify_reparent() to produce trace output. That function was
> removed in 5bf546755c (chdir-notify: drop unused
> `chdir_notify_reparent()`, 2026-06-25), which left `name` with no
> remaining consumers.
> 
> Prior to that removal, most callers had already stopped passing a
> meaningful name, switching to NULL in 1f43ff2c7e (refs: unregister
> reference stores from "chdir_notify", 2026-06-25) and 0de2467e6c
> (odb/source-packed: start converting to a proper `struct odb_source`,
> 2026-06-17).
> 
> Since no caller has populated `name` with real data for some time,
> and its last consumer is gone, drop it from chdir_notify_register(),
> chdir_notify_unregister(), and the callback signature to simplify
> the API.

Thanks, this description summarizes the situation nicely.

-Peff

      reply	other threads:[~2026-08-15  5:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 19:38 [PATCH] chdir-notify.h: Removed unused param 'name' Colin Hinton
2026-08-14 20:31 ` Jeff King
2026-08-14 20:42   ` Junio C Hamano
2026-08-14 21:42 ` [PATCH v2] " Colin Hinton
2026-08-15  5:12   ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260815051213.GA26013@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=colinlewishinton@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox