Git development
 help / color / mirror / Atom feed
From: Tuomas Ahola <taahol@utu.fi>
To: Patrick Steinhardt <ps@pks.im>
Cc: Hardik Kumar <hardikxk@gmail.com>, <git@vger.kernel.org>
Subject: Re: [PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh
Date: Mon, 31 Aug 2026 21:20:52 +0300	[thread overview]
Message-ID: <20260831182052.ppylY%taahol@utu.fi> (raw)
In-Reply-To: <apUmRknf8gnd-Izp@pks.im>

Patrick Steinhardt <ps@pks.im> wrote:

> On Fri, Aug 28, 2026 at 02:38:01PM +0530, Hardik Kumar wrote:
> 
> > NFC only updating a comment and a test_description
> 
> I have no idea what this means.
> 

"No functional changes", I guess.  But spelling it out in the commit log
message would of course be preferable.

      reply	other threads:[~2026-08-31 18:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28  9:08 [PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh Hardik Kumar
2026-08-31  6:59 ` Patrick Steinhardt
2026-08-31 18:20   ` Tuomas Ahola [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831182052.ppylY%taahol@utu.fi \
    --to=taahol@utu.fi \
    --cc=git@vger.kernel.org \
    --cc=hardikxk@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox