Git development
 help / color / mirror / Atom feed
From: Ted Nyman <tnyman@openai.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Patrick Steinhardt <ps@pks.im>, Taylor Blau <me@ttaylorr.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] fetch-pack: trace packfile URI downloads
Date: Mon,  7 Sep 2026 14:24:54 -0700	[thread overview]
Message-ID: <20260907212454.80627-1-tnyman@openai.com> (raw)
In-Reply-To: <anskQP_xB-Xw3nug@pks.im>

On Tue, Aug 11, 2026 at 03:31:44PM +0200, Patrick Steinhardt wrote:
> Anyway, having this in a separate test would've been nice, but that
> doesn't warrant a reroll in my eyes. So overall, this patch looks good
> to me, thanks!

Thanks for reviewing, Patrick.

Junio, a gentle ping on this patch. Patrick was positive on it and didn't
think the test organization warranted a reroll. Is there anything else
you'd like me to address before picking it up? I'm happy to split out the
tracing checks into a separate test or refresh the patch if that helps.

Thanks,
Ted

  reply	other threads:[~2026-09-07 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-26  8:33 [PATCH] fetch-pack: trace packfile URI downloads Ted Nyman
2026-08-11 13:31 ` Patrick Steinhardt
2026-09-07 21:24   ` Ted Nyman [this message]
2026-09-08  3:27     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907212454.80627-1-tnyman@openai.com \
    --to=tnyman@openai.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox