From: "Mark C. Chu-Carroll via B4 Relay" <devnull+markchucarroll.fastmail.com@kernel.org>
To: git@vger.kernel.org
Cc: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
Subject: [PATCH 1/3] Update t4001 to use modern syntax.
Date: Tue, 08 Sep 2026 15:44:53 -0400 [thread overview]
Message-ID: <20260908-modernize-t4001-v1-1-cab3933a173f@fastmail.com> (raw)
In-Reply-To: <20260908-modernize-t4001-v1-0-cab3933a173f@fastmail.com>
From: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
---
t/t4001-diff-rename.sh | 31 ++++++++++++++++---------------
t/t4009-diff-rename-4.sh | 8 ++++----
2 files changed, 20 insertions(+), 19 deletions(-)
diff --git a/t/t4001-diff-rename.sh b/t/t4001-diff-rename.sh
index ad474100af..2aa161c217 100755
--- a/t/t4001-diff-rename.sh
+++ b/t/t4001-diff-rename.sh
@@ -88,28 +88,29 @@ test_expect_success 'setup' '
EOF
'
-test_expect_success \
- 'update-index --add a file.' \
- 'git update-index --add path0'
+test_expect_success 'update-index --add a file.' '
+ git update-index --add path0
+'
-test_expect_success \
- 'write that tree.' \
- 'tree=$(git write-tree) && echo $tree'
+test_expect_success 'write that tree.' '
+ tree=$(git write-tree) && echo $tree
+'
sed -e 's/line/Line/' <path0 >path1
rm -f path0
-test_expect_success \
- 'renamed and edited the file.' \
- 'git update-index --add --remove path0 path1'
-test_expect_success \
- 'git diff-index -p -M after rename and editing.' \
- 'git diff-index -p -M $tree >current'
+test_expect_success 'renamed and edited the file.' '
+ git update-index --add --remove path0 path1
+'
+
+test_expect_success 'git diff-index -p -M after rename and editing.' '
+ git diff-index -p -M $tree >current
+'
-test_expect_success \
- 'validate the output.' \
- 'compare_diff_patch current expected'
+test_expect_success 'validate the output.' '
+ compare_diff_patch current expected
+'
test_expect_success 'test diff.renames=true' '
git -c diff.renames=true diff --cached $tree >current &&
diff --git a/t/t4009-diff-rename-4.sh b/t/t4009-diff-rename-4.sh
index 59e71e3acd..8f86dc7274 100755
--- a/t/t4009-diff-rename-4.sh
+++ b/t/t4009-diff-rename-4.sh
@@ -19,10 +19,10 @@ test_expect_success \
tree=$(git write-tree) &&
echo $tree'
-test_expect_success \
- 'prepare work tree' \
- 'sed -e 's/HOWEVER/However/' <COPYING >COPYING.1 &&
- sed -e 's/GPL/G.P.L/g' <COPYING >COPYING.2 &&
+
+test_expect_success 'prepare work tree' '
+ sed -e "s/HOWEVER/However/" <COPYING >COPYING.1 &&
+ sed -e "s/GPL/G.P.L/g" <COPYING >COPYING.2 &&
rm -f COPYING &&
c1=$(git hash-object COPYING.1) &&
c2=$(git hash-object COPYING.2) &&
--
2.53.0
next prev parent reply other threads:[~2026-09-08 19:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 19:44 [PATCH 0/3] Update t40* tests to use modern style Mark C. Chu-Carroll via B4 Relay
2026-09-08 19:44 ` Mark C. Chu-Carroll via B4 Relay [this message]
2026-09-08 20:48 ` [PATCH 1/3] Update t4001 to use modern syntax Junio C Hamano
2026-09-08 19:44 ` [PATCH 2/3] Update t4009 to use modern style Mark C. Chu-Carroll via B4 Relay
2026-09-08 19:44 ` [PATCH 3/3] Update t4010 " Mark C. Chu-Carroll via B4 Relay
2026-09-10 17:07 ` [PATCH v2 0/3] Update t40* tests " Mark C. Chu-Carroll via B4 Relay
2026-09-10 17:07 ` [PATCH v2 1/3] Update t4001 to use modern syntax Mark C. Chu-Carroll via B4 Relay
2026-09-10 17:56 ` Junio C Hamano
2026-09-10 17:07 ` [PATCH v2 2/3] Update t4009 to use modern style Mark C. Chu-Carroll via B4 Relay
2026-09-10 17:07 ` [PATCH v2 3/3] Update t4010 " Mark C. Chu-Carroll via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908-modernize-t4001-v1-1-cab3933a173f@fastmail.com \
--to=devnull+markchucarroll.fastmail.com@kernel.org \
--cc=git@vger.kernel.org \
--cc=markchucarroll@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox