Git development
 help / color / mirror / Atom feed
From: Tuomas Ahola <taahol@utu.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH] lint-gitlink: don't use empty lower bound in .{0,8}
Date: Tue, 8 Sep 2026 09:43:05 +0300	[thread overview]
Message-ID: <20260908064305.PIgoB%taahol@utu.fi> (raw)
In-Reply-To: <xmqqo6e8za5e.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> wrote:

> Tuomas Ahola <taahol@utu.fi> writes:
> 
> > The regex quantifier {,n} was added in Perl 5.34.0 as a shorthand
> > for {0,n}.  That makes it too new an introduction for Git which
> > targets Perl 5.26.0.
> >
> > Even though Documentation/lint-gitlink.perl is a development helper
> > script, let's stick to the general Perl version requirement for
> > consistency, and use an explicit zero in .{0,8}.
> 
> I am curious how you found this.
> 
> I somehow find it unlikely that you were sticking to Perl 5.26, ran
> "make -C Documentation lint-docs" and saw your tad old Perl complain
> for syntax too new.

Well, that's what happened (although my Perl wasn't exactly 5.26).

> 
> Perl 5.26 is from May 2017 while Perl 5.34 is from May 2021 if
> https://cpan.org/src/ is to be believed.  
> 
> Will queue.  Thanks.

      reply	other threads:[~2026-09-08  6:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 18:48 [PATCH] lint-gitlink: don't use empty lower bound in .{0,8} Tuomas Ahola
2026-09-08  3:37 ` Junio C Hamano
2026-09-08  6:43   ` Tuomas Ahola [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908064305.PIgoB%taahol@utu.fi \
    --to=taahol@utu.fi \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox