Git development
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: [PATCH v2 0/4] make: precompile "git-compat-util.h"
Date: Tue, 15 Sep 2026 08:09:48 +0200	[thread overview]
Message-ID: <20260915060952.569535-1-szeder.dev@gmail.com> (raw)
In-Reply-To: <20260909195006.2179119-1-szeder.dev@gmail.com>

Update our Makefile to make use of the recently introduced precompiled
header to make builds faster (on my setup by about 35%).

Changes since v1:
  - Update the commit message of patch 3/4 per Junio's suggestion.


SZEDER Gábor (4):
  Makefile: remove XDIFF_OBJS initialization
  cmake: remove any "$(*_OBJS)" variables when parsing Makefile for
    sources
  Makefile: reintroduce REFTABLE_OBJS
  Makefile: precompile "git-compat-util.h"

 .gitignore                          |  1 +
 Makefile                            | 59 +++++++++++++++++++----------
 contrib/buildsystems/CMakeLists.txt |  6 ++-
 3 files changed, 45 insertions(+), 21 deletions(-)

Range-diff against v1:
1:  d52a1476d1 = 1:  d52a1476d1 Makefile: remove XDIFF_OBJS initialization
2:  5d60181efd = 2:  5d60181efd cmake: remove any "$(*_OBJS)" variables when parsing Makefile for sources
3:  0296c6cffc ! 3:  cfc77c0b2c Makefile: reintroduce REFTABLE_OBJS
    @@ Metadata
      ## Commit message ##
         Makefile: reintroduce REFTABLE_OBJS
     
    -    Object files under "reftable/" used to be listed in the REFTABLE_OBJS
    -    Makefile variable so we could build a static library from them.  This
    -    static library was removed in f3b4c89d59 (make: delete REFTABLE_LIB,
    -    add reftable to LIB_OBJS, 2025-10-02), along with filling
    -    REFTALBE_OBJS with object files.
    +    In the next commit we are about to precompile "git-compat-util.h" with
    +    "make" to reduce build times.  But using the precompiled header should
    +    not change what actually gets compiled, therefore a source file can
    +    only be compiled using the precompiled header if the first included
    +    header file is "git-compat-util.h".
     
    -    However, the reftable source files are kind of special, because the
    -    reftable implementation is supposed to be easily includable in other
    -    projects.  Therefore, the reftable source files don't include
    +    The reftable source files are kind of special, because the reftable
    +    implementation is supposed to be easily includable in other projects.
    +    Therefore, the reftable source files don't include
         "git-compat-util.h", with the sole exception of the purposefully
         project-specific "reftable/system.c".  Consequently, they shouldn't be
    -    compiled with our precompiled header, as it does include
    -    "git-compat-util.h".
    +    compiled with our precompiled header.
    +
    +    List object files under "reftable" in the REFTABLE_OBJS Makefile
    +    variable, so in the next commit we'll be able to easily filter them
    +    out and keep building them the old way, without the precompiled
    +    header.
     
    -    Resurrect listing object files under "reftable/" in REFTABLE_OBJS (but
    -    not the static library), so in the next commit we'll be able to easily
    -    filter them out and keep building them the old way, without the
    -    precompiled header.
    +    Note that object files under "reftable/" used to be listed in
    +    REFTABLE_OBJS so we could build a static library from them.  This
    +    static library was removed in f3b4c89d59 (make: delete REFTABLE_LIB,
    +    add reftable to LIB_OBJS, 2025-10-02), along with filling
    +    REFTALBE_OBJS with object files.  This change essentially reverts the
    +    removal of REFTABLE_OBJS, but not the building of that static library.
     
         Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
     
4:  ce9fd91413 = 4:  a933be0664 Makefile: precompile "git-compat-util.h"
-- 
2.56.0.rc0.467.ge054dd0dd6


  parent reply	other threads:[~2026-09-15  6:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 19:50 [PATCH 0/4] make: precompile "git-compat-util.h" SZEDER Gábor
2026-09-09 19:50 ` [PATCH 1/4] Makefile: remove XDIFF_OBJS initialization SZEDER Gábor
2026-09-09 19:50 ` [PATCH 2/4] cmake: remove any "$(*_OBJS)" variables when parsing Makefile for sources SZEDER Gábor
2026-09-09 19:50 ` [PATCH 3/4] Makefile: reintroduce REFTABLE_OBJS SZEDER Gábor
2026-09-09 21:07   ` Junio C Hamano
2026-09-09 19:50 ` [PATCH 4/4] Makefile: precompile "git-compat-util.h" SZEDER Gábor
2026-09-09 19:57   ` SZEDER Gábor
2026-09-15  6:09 ` SZEDER Gábor [this message]
2026-09-15  6:09   ` [PATCH v2 1/4] Makefile: remove XDIFF_OBJS initialization SZEDER Gábor
2026-09-15  6:09   ` [PATCH v2 2/4] cmake: remove any "$(*_OBJS)" variables when parsing Makefile for sources SZEDER Gábor
2026-09-15  6:09   ` [PATCH v2 3/4] Makefile: reintroduce REFTABLE_OBJS SZEDER Gábor
2026-09-15  6:09   ` [PATCH v2 4/4] Makefile: precompile "git-compat-util.h" SZEDER Gábor
2026-09-24 23:52     ` Jeff King
2026-09-25  9:25       ` SZEDER Gábor
2026-10-03 19:00     ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260915060952.569535-1-szeder.dev@gmail.com \
    --to=szeder.dev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox