From: Jeff King <peff@peff.net>
To: Jon Simons <jon@jonsimons.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] p5551: fix repeated runs with update-ref --no-deref
Date: Mon, 28 Sep 2026 00:05:11 -0400 [thread overview]
Message-ID: <20260928040511.GA498426@coredump.intra.peff.net> (raw)
In-Reply-To: <20260926180648.60770-1-jon@jonsimons.org>
On Sat, Sep 26, 2026 at 02:06:48PM -0400, Jon Simons wrote:
> Update p5551-fetch-rescan.sh to pass `--no-deref` when deleting child
> test refs before each measured `git fetch`. Otherwise, for repeated
> runs, the second iteration will fail with:
>
> fatal: multiple updates for 'refs/remotes/origin/master' (including
> one via symref 'refs/remotes/origin/HEAD') are not allowed
>
> Starting with 3f763ddf28 (fetch: set remote/HEAD if it does not exist,
> 2024-11-22), `git fetch` instantiates the HEAD symref.
>
> The test, introduced in 7893bf1720 (p5551: add a script to test fetch
> pack-dir rescans, 2017-11-20), predates that.
Thanks, the explanation and patch both make sense.
This test could probably benefit from using --setup (which also didn't
exist back when this test was written). But that's nothing new, and well
outside the scope of your patch.
-Peff
next prev parent reply other threads:[~2026-09-28 4:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 18:06 [PATCH] p5551: fix repeated runs with update-ref --no-deref Jon Simons
2026-09-28 4:05 ` Jeff King [this message]
2026-09-28 18:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928040511.GA498426@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jon@jonsimons.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox