From: Jeff King <peff@peff.net>
To: Ignacio Encinas <ignacio@iencinas.com>
Cc: Isabella Caselli <bellacaselli20@gmail.com>, git@vger.kernel.org
Subject: Re: hostname: includeIf condition — anyone already working on this?
Date: Tue, 29 Sep 2026 14:28:50 -0400 [thread overview]
Message-ID: <20260929182850.GB1710046@coredump.intra.peff.net> (raw)
In-Reply-To: <DLRSIZ3JV2DF.10GG1YB2D8DHW@iencinas.com>
On Tue, Sep 29, 2026 at 01:14:34PM +0100, Ignacio Encinas wrote:
> > Yes, that is the tricky part. :) There were some patches in 2024:
> >
> > https://lore.kernel.org/git/20240307205006.467443-1-ignacio@iencinas.com/
> >
> > where the issue came up. Based on my recollection and a quick skim of
> > the thread, I think the consensus was that it's OK to document that it
> > is system-dependent whether we'll match against a short of fully
> > qualified hostname. But exposing our view of the hostname via git-var
> > (e.g., "git var GIT_HOSTNAME") might be a helpful debugging aid.
> >
> > It looks like after review on v3 of the series we never saw more. I'd
> > guess the author (cc'd) just never got around to pushing it forward.
>
> That's what happened. Similar to Isabella, I was looking for a small
> contribution but it ended up being more complicated than expected. I got
> a bit overwhelmed and decided to drop it.
>
> I kept wondering if I should have communicated that, so apologies if
> that was the case.
Nah, it's not a big deal. This is open source, so everybody is here
voluntarily, and it's normal for people to come in and out as time and
interest permits. Plus the very reason that people end up dropping a
series (getting overwhelmed) often makes it hard to decide whether and
when to write the "I'm dropping this" email. :)
> I hope the discussion from 2024 is at least helpful now if this ends up
> being implemented by Isabella.
Yeah, I think there's a lot of good discussion there, and the patches
themselves can probably give a boost to another attempt. Even if we did
not finish it back then, thank you for the work so far.
-Peff
next prev parent reply other threads:[~2026-09-29 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 23:43 hostname: includeIf condition — anyone already working on this? Isabella Caselli
2026-09-29 1:44 ` Jeff King
2026-09-29 12:14 ` Ignacio Encinas
2026-09-29 18:28 ` Jeff King [this message]
2026-09-29 19:55 ` Junio C Hamano
2026-10-02 1:52 ` Isabella Caselli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929182850.GB1710046@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bellacaselli20@gmail.com \
--cc=git@vger.kernel.org \
--cc=ignacio@iencinas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox