Git development
 help / color / mirror / Atom feed
From: Michele Locati <michele@locati.it>
To: Patrick Steinhardt <ps@pks.im>
Cc: Grant Moyer <dev@grantmoyer.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] filter-branch: fix commit map init from state branch
Date: Thu,  1 Oct 2026 08:33:06 +0200	[thread overview]
Message-ID: <20261001063306.616-1-michele@locati.it> (raw)
In-Reply-To: <ar3xSurCd0-yDruA@pks.im>

Hi Patrick,

> simple blob stored in "$state_branch:filter.map" with the format
> "$to_commit:$from_commit".

Small correction: the format is "$from_commit:$to_commit" (the original
commit first, then the rewritten one), that's what the fix restores.

The test_when_finished cleanup sounds good to me.

Since I'm listed as co-author:

Signed-off-by: Michele Locati <michele@locati.it>

Thanks,
Michele

  reply	other threads:[~2026-10-01  6:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-01  3:31 [PATCH] fiter-branch: fix commit map init from state branch Grant Moyer
2026-09-29 14:31 ` Michele Locati
2026-09-30 14:40 ` Patrick Steinhardt
2026-09-30 15:48   ` Grant Moyer
2026-09-30 16:08     ` Patrick Steinhardt
2026-09-30 20:38   ` Michele Locati
2026-10-01  1:23 ` [PATCH v2] filter-branch: " Grant Moyer
2026-10-01  5:36   ` Patrick Steinhardt
2026-10-01  6:33     ` Michele Locati [this message]
2026-10-01 16:10   ` Junio C Hamano
2026-10-03  1:01   ` [PATCH v3] " Grant Moyer
2026-10-05  6:11     ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001063306.616-1-michele@locati.it \
    --to=michele@locati.it \
    --cc=dev@grantmoyer.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox