From: Victor Okafor <vua.okafor@gmail.com>
To: git@vger.kernel.org
Cc: Victor Okafor <vua.okafor@gmail.com>
Subject: [PATCH] t0200: use path checking helpers
Date: Wed, 14 Oct 2026 11:56:13 +0100 [thread overview]
Message-ID: <20261014105613.49334-1-vua.okafor@gmail.com> (raw)
Replace direct directory and file checks with the corresponding
test helpers in t/t0200-gettext-basic.sh.
Instances were located using:
git grep -n -E 'test -[efds]' -- 't/t[0-9]*.sh'
Signed-off-by: Victor Okafor <vua.okafor@gmail.com>
---
t/t0200-gettext-basic.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t0200-gettext-basic.sh b/t/t0200-gettext-basic.sh
index 8db26c1ada..177cf658fd 100755
--- a/t/t0200-gettext-basic.sh
+++ b/t/t0200-gettext-basic.sh
@@ -31,12 +31,12 @@ test_expect_success 'xgettext sanity: Comment extraction with --add-comments sto
'
test_expect_success GETTEXT 'sanity: $TEXTDOMAINDIR exists without NO_GETTEXT=YesPlease' '
- test -d "$TEXTDOMAINDIR" &&
+ test_path_is_dir "$TEXTDOMAINDIR" &&
test "$TEXTDOMAINDIR" = "$GIT_TEXTDOMAINDIR"
'
test_expect_success GETTEXT 'sanity: Icelandic locale was compiled' '
- test -f "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
+ test_path_is_file "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
'
# TODO: When we have more locales, generalize this to test them
--
2.55.0
next reply other threads:[~2026-10-14 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 10:56 Victor Okafor [this message]
2026-10-14 14:45 ` [PATCH] t0200: use path checking helpers Usman Akinyemi
2026-10-14 19:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014105613.49334-1-vua.okafor@gmail.com \
--to=vua.okafor@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox