From: kerylefondji7@gmail.com
To: git@vger.kernel.org
Cc: phillipwood123@gmail.com, gitster@pobox.com,
christiancouder@gmail.com, siddharthasthana31@gmail.com,
Keryle Fondji <kerylefondji7@gmail.com>
Subject: [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_()
Date: Mon, 19 Oct 2026 16:27:24 +0100 [thread overview]
Message-ID: <20261019152725.714-1-kerylefondji7@gmail.com> (raw)
In-Reply-To: <1a15474a4114ba8b>
From: Keryle Fondji <kerylefondji7@gmail.com>
Replace _() with Q_() in the 'path too long' error message. Although
pathlen is always greater than 0xffff when this error is hit, Q_() is
required to support correct translation for languages that require
different plural forms depending on the count.
Signed-off-by: Keryle Fondji <kerylefondji7@gmail.com>
---
archive-zip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/archive-zip.c b/archive-zip.c
index 6f73ca6d58..e4f8ef5a36 100644
--- a/archive-zip.c
+++ b/archive-zip.c
@@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args,
}
if (pathlen > 0xffff) {
- return error(_("path too long (%d chars, SHA1: %s): %s"),
+ return error(Q_("path too long (%d char, SHA1: %s): %s", "path too long (%d chars, SHA1: %s): %s", pathlen),
(int)pathlen, oid_to_hex(oid), path);
}
--
2.53.0
next parent reply other threads:[~2026-10-19 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1a15474a4114ba8b>
2026-10-19 15:27 ` kerylefondji7 [this message]
2026-10-20 9:42 ` [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_() Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019152725.714-1-kerylefondji7@gmail.com \
--to=kerylefondji7@gmail.com \
--cc=christiancouder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillipwood123@gmail.com \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox