Git development
 help / color / mirror / Atom feed
From: Dorine Tipo <dorine.a.tipo@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, kaartic.sivaraam@gmail.com,
	christian.couder@gmail.com, siddharthasthana31@gmail.com,
	usmanakinyemi202@gmail.com, Dorine Tipo <dorine.a.tipo@gmail.com>
Subject: [Outreachy PATCH v2 1/2] t0410: use rev-parse to get the subtree OID
Date: Tue, 20 Oct 2026 19:01:26 +0300	[thread overview]
Message-ID: <20261020160127.29096-2-dorine.a.tipo@gmail.com> (raw)
In-Reply-To: <20261020160127.29096-1-dorine.a.tipo@gmail.com>

The 'rev-list stops traversal at missing and promised tree' test gets
the OID of a_dir by piping 'git ls-tree' through grep, head and cut.

The pipeline goes against t/README which says not to pipe the output
of a git command, since only the last command's exit code is kept.
It also silently assumes that the first tree in the ls-tree output is
the one we want, without checking which path it is stored at.
And 'cut -b13-52' also assumes a 40-character SHA-1 name, so under
SHA-256 TREE2 holds an abbreviated OID.

Use 'git rev-parse HEAD:a_dir' instead. It names the directory we are
interested in explicitly and returns the full OID in a single command,
the same way TREE is computed with 'git rev-parse foo^{tree}' just
above.

Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 t/t0410-partial-clone.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh
index 788e9a1631..a24b663f73 100755
--- a/t/t0410-partial-clone.sh
+++ b/t/t0410-partial-clone.sh
@@ -405,7 +405,7 @@ test_expect_success 'rev-list stops traversal at missing and promised tree' '
 	TREE=$(git -C repo rev-parse foo^{tree}) &&
 
 	# a tree referenced by HEAD^{tree} (tree referenced from tree)
-	TREE2=$(git -C repo ls-tree HEAD^{tree} | grep " tree " | head -1 | cut -b13-52) &&
+	TREE2=$(git -C repo rev-parse HEAD:a_dir) &&
 
 	promise_and_delete "$TREE" &&
 	promise_and_delete "$TREE2" &&
-- 
2.34.1


  reply	other threads:[~2026-10-20 16:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 13:45 [Outreachy PATCH 0/2] t0410: fix exit code and hash assumptions in the missing-tree test Dorine Tipo
2026-10-14 13:45 ` [Outreachy PATCH 1/2] t0410: use rev-parse to get the subtree OID Dorine Tipo
2026-10-14 20:01   ` Junio C Hamano
2026-10-15 15:47     ` Dorine Tipo
2026-10-14 13:45 ` [Outreachy PATCH 2/2] t0410: keep git's exit code in test_grep calls Dorine Tipo
2026-10-20 16:01 ` [Outreachy PATCH v2 0/2] t0410: fix exit code and hash assumptions in the missing-tree test Dorine Tipo
2026-10-20 16:01   ` Dorine Tipo [this message]
2026-10-20 16:01   ` [Outreachy PATCH v2 2/2] t0410: keep git's exit code in test_grep calls Dorine Tipo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261020160127.29096-2-dorine.a.tipo@gmail.com \
    --to=dorine.a.tipo@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=siddharthasthana31@gmail.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox