Git development
 help / color / mirror / Atom feed
From: Aniket Gupta <aniketgupta3001@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, christian.couder@gmail.com, cat@malon.dev,
	belkid98@gmail.com, ps@pks.im, phillip.wood123@gmail.com
Subject: [PATCH 0/4] environment: move line ending config variables into repo_config_values
Date: Sat, 24 Oct 2026 22:00:08 +0000	[thread overview]
Message-ID: <20261024220012.486-1-aniketgupta3001@gmail.com> (raw)

Hi,

This series moves the global variables behind core.autocrlf, core.eol
and core.safecrlf into 'struct repo_config_values' to continue the
libification effort.

The first patch passes 'repo' to the working tree conversion
functions which need it to read the values. The other three move one
variable each just like the earlier conversions.

An alternative to passing 'repo' would be to store the resolved values
in 'struct conv_attrs'. I went with passing it since that is what the
earlier conversions did, but I can change it if you prefer.

Aniket Gupta (4):
  convert: pass 'repo' to the working tree conversion functions
  environment: move auto_crlf into repo_config_values
  environment: move core_eol into repo_config_values
  environment: move global_conv_flags_eol into repo_config_values

 combine-diff.c      |   4 +-
 convert.c           | 107 +++++++++++++++++++++++++++++++-------------
 convert.h           |  60 +++++++------------------
 diff.c              |   2 +-
 entry.c             |  16 ++++---
 environment.c       |  43 +++++++++++++-----
 environment.h       |  26 +++++++++++
 object-file.c       |  11 +++--
 parallel-checkout.c |   8 ++--
 9 files changed, 177 insertions(+), 100 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-10-24 22:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 22:00 Aniket Gupta [this message]
2026-10-24 22:00 ` [PATCH 1/4] convert: pass 'repo' to the working tree conversion functions Aniket Gupta
2026-10-24 22:00 ` [PATCH 2/4] environment: move auto_crlf into repo_config_values Aniket Gupta
2026-10-24 22:00 ` [PATCH 3/4] environment: move core_eol " Aniket Gupta
2026-10-24 22:00 ` [PATCH 4/4] environment: move global_conv_flags_eol " Aniket Gupta
2026-10-26 12:27 ` [PATCH 0/4] environment: move line ending config variables " Patrick Steinhardt
2026-10-26 13:10   ` Aniket Gupta
2026-10-26 13:25     ` Patrick Steinhardt
2026-10-26 15:53   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024220012.486-1-aniketgupta3001@gmail.com \
    --to=aniketgupta3001@gmail.com \
    --cc=belkid98@gmail.com \
    --cc=cat@malon.dev \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox