From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Git mailing list <git@vger.kernel.org>
Cc: Patrick Steinhardt <ps@pks.im>
Subject: [PATCH v2 1/2] unit-tests: reshuffle NOOP arguments to maintain order
Date: Mon, 26 Oct 2026 12:48:21 +0530 [thread overview]
Message-ID: <20261026-ks-unit-tests-ignore-long-tests-v2-1-eaab5657c19c@gmail.com> (raw)
In-Reply-To: <20261026-ks-unit-tests-ignore-long-tests-v2-0-eaab5657c19c@gmail.com>
Ever since 9faf3963b6 (t: introduce compatibility options to
clar-based tests, 2024-12-13), our clar tests have a few NOOP
arguments in order to accept the same arguments that our integration
tests accept. This makes it easy to pass in test arguments when both
unit and integration tests are run together such as via:
$ meson test -v --test-args='-ix'
On a quick scan, the order of the NOOP arguments seem to be
alphabetical. That is only until you notice that 'with-dashes'
appears out of order.
Fix this by moving it into its appropriate place thus ensuring
they are in alphabetical order. This makes it easy for future
patches to not worry about where to place a NOOP argument
that is not yet in the list.
Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
---
t/unit-tests/unit-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/unit-tests/unit-test.c b/t/unit-tests/unit-test.c
index 752fb38fb3..d066c8a4c8 100644
--- a/t/unit-tests/unit-test.c
+++ b/t/unit-tests/unit-test.c
@@ -33,12 +33,12 @@ int cmd_main(int argc, const char **argv)
OPT_NOOP_ARG(0, "root"),
OPT_NOOP_ARG(0, "stress"),
OPT_NOOP_NOARG(0, "tee"),
- OPT_NOOP_NOARG(0, "with-dashes"),
OPT_NOOP_ARG(0, "valgrind"),
OPT_NOOP_ARG(0, "valgrind-only"),
OPT_NOOP_NOARG('v', "verbose"),
OPT_NOOP_NOARG('V', "verbose-log"),
OPT_NOOP_ARG(0, "verbose-only"),
+ OPT_NOOP_NOARG(0, "with-dashes"),
OPT_NOOP_NOARG('x', NULL),
OPT_END(),
};
--
2.56.0.99.g5a7d1e8045.dirty
next prev parent reply other threads:[~2026-10-26 7:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 7:18 [PATCH v2 0/2] Make our clar tests ignore the long-tests argument Kaartic Sivaraam
2026-10-26 7:18 ` Kaartic Sivaraam [this message]
2026-10-26 7:18 ` [PATCH v2 2/2] unit-tests: ignore --long-tests Kaartic Sivaraam
-- strict thread matches above, loose matches on Subject: below --
2026-10-26 7:31 [PATCH v2 0/2] Make our clar tests ignore the long-tests argument Kaartic Sivaraam
2026-10-26 7:31 ` [PATCH v2 1/2] unit-tests: reshuffle NOOP arguments to maintain order Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026-ks-unit-tests-ignore-long-tests-v2-1-eaab5657c19c@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox