From: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
To: git@vger.kernel.org
Cc: christian.couder@gmail.com, usmanakinyemi202@gmail.com,
siddharthasthana31@gmail.com, kaartic.sivaraam@gmail.com,
Okhuomon Ajayi <okhuomonajayi54@gmail.com>
Subject: [Outreachy PATCH] bundle-uri: use the passed repository for refs and tracing
Date: Wed, 28 Oct 2026 10:34:55 +0100 [thread overview]
Message-ID: <20261028093455.76247-1-okhuomonajayi54@gmail.com> (raw)
unbundle_from_file() receives r and unbundles the objects into
it, but reads and writes the refs in the_repository.
fetch_bundle_uri() also has r, but uses the_repository for its
trace2 region.
Use r for both.
Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
unbundle_from_file() still depends on the_repository through
fetch_pack_fsck_objects(), which reads fetch.fsckObjects and
transfer.fsckObjects from the_repository's config. I left that out.
bundle-uri.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/bundle-uri.c b/bundle-uri.c
index 2bb2eb99e4..0d612d92fe 100644
--- a/bundle-uri.c
+++ b/bundle-uri.c
@@ -448,9 +448,9 @@ static int unbundle_from_file(struct repository *r, const char *file)
strbuf_setlen(&bundle_ref, bundle_prefix_len);
strbuf_addstr(&bundle_ref, branch_name);
- has_old = !refs_read_ref(get_main_ref_store(the_repository),
+ has_old = !refs_read_ref(get_main_ref_store(r),
bundle_ref.buf, &old_oid);
- refs_update_ref(get_main_ref_store(the_repository),
+ refs_update_ref(get_main_ref_store(r),
"fetched bundle", bundle_ref.buf, oid,
has_old ? &old_oid : NULL,
0, UPDATE_REFS_MSG_ON_ERR);
@@ -859,7 +859,7 @@ int fetch_bundle_uri(struct repository *r, const char *uri,
.id = xstrdup(""),
};
- trace2_region_enter("fetch", "fetch-bundle-uri", the_repository);
+ trace2_region_enter("fetch", "fetch-bundle-uri", r);
init_bundle_list(&list);
@@ -886,7 +886,7 @@ int fetch_bundle_uri(struct repository *r, const char *uri,
for_all_bundles_in_list(&list, unlink_bundle, NULL);
clear_bundle_list(&list);
clear_remote_bundle_info(&bundle, NULL);
- trace2_region_leave("fetch", "fetch-bundle-uri", the_repository);
+ trace2_region_leave("fetch", "fetch-bundle-uri", r);
return result;
}
base-commit: 37b3475fb530c14109211faca33716a173db61ed
--
2.56.0
next reply other threads:[~2026-10-28 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 9:34 Okhuomon Ajayi [this message]
2026-10-28 11:05 ` [Outreachy PATCH] bundle-uri: use the passed repository for refs and tracing Karthik Nayak
2026-10-28 11:18 ` Okhuomon Ajayi
2026-10-28 16:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028093455.76247-1-okhuomonajayi54@gmail.com \
--to=okhuomonajayi54@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=siddharthasthana31@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox