From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 1/4] ident: remove unused author_ident_sufficiently_given()
Date: Fri, 30 Oct 2026 10:39:53 -0700 [thread overview]
Message-ID: <20261030173956.585250-2-gitster@pobox.com> (raw)
In-Reply-To: <20261030173956.585250-1-gitster@pobox.com>
A pair of functions {author,committer}_ident_sufficiently_given()
were created to replace user_ident_explicitly_given() in d6991ceedc
(ident: keep separate "explicit" flags for author and committer,
2012-11-14).
But author_ident_sufficiently_given() is never used in our history.
We only check if committer ident is sufficiently given and use it to
nudge the user to set user.{name,email} configuration variables.
Remove the unused author_ident_sufficiently_given() function.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
ident.c | 5 -----
ident.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/ident.c b/ident.c
index 0b7aacecd7..eb73d073d8 100644
--- a/ident.c
+++ b/ident.c
@@ -602,11 +602,6 @@ int committer_ident_sufficiently_given(void)
return ident_is_sufficient(committer_ident_explicitly_given);
}
-int author_ident_sufficiently_given(void)
-{
- return ident_is_sufficient(author_ident_explicitly_given);
-}
-
static int set_ident(const char *var, const char *value)
{
if (!strcmp(var, "author.name")) {
diff --git a/ident.h b/ident.h
index 3c03403879..7e60e36415 100644
--- a/ident.h
+++ b/ident.h
@@ -60,7 +60,6 @@ const char *fmt_ident(const char *name, const char *email,
const char *fmt_name(enum want_ident);
int committer_ident_sufficiently_given(void);
-int author_ident_sufficiently_given(void);
struct config_context;
int git_ident_config(const char *, const char *, const struct config_context *,
--
2.56.0-486-gd49ba3b80a
next prev parent reply other threads:[~2026-10-30 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 17:39 [PATCH 0/4] mark symbols that are unnecessarily public static Junio C Hamano
2026-10-30 17:39 ` Junio C Hamano [this message]
2026-10-30 17:39 ` [PATCH 2/4] add -i: hide init/clear_add_i_state() functions Junio C Hamano
2026-10-30 17:39 ` [PATCH 3/4] read-cache: hide refresh_cache_entry() Junio C Hamano
2026-10-30 17:39 ` [PATCH 4/4] unpack-trees: hide verify_uptodate() Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030173956.585250-2-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox