Git development
 help / color / mirror / Atom feed
From: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, mail@thomasbachem.com, ps@pks.im, ttaylorr@openai.com
Subject: [PATCH v3 0/2] maintenance: improve lock acquisition failure handling
Date: Wed,  4 Nov 2026 17:34:20 +0000	[thread overview]
Message-ID: <20261104173422.20725-1-pushkarkumarsingh1970@gmail.com> (raw)
In-Reply-To: <20261102122955.143018-2-pushkarkumarsingh1970@gmail.com>

Greetings,

This series improves how "git maintenance" handles failures to
acquire the maintenance lock.

The first patch changes the handling of lock acquisition failures
so that manual invocations report an error and return a non-zero
exit status, while automatic invocations print a warning and exit
successfully.

The second patch adds a Trace2 data event to make it easier to
identify cases where automatic maintenance is repeatedly skipped
due to lock acquisition failures.

Changes in v3:
- Split the changes into two separate patches: one for lock
  failure handling and another for Trace2 instrumentation.
- Use `strerror(err)` consistently for reporting lock acquisition
  failures in Trace2.
- Deduplicate the diagnostic message construction while preserving
  the distinction between warnings and errors.

Thanks,
Pushkar

Pushkar Singh (2):
  maintenance: report lock acquisition failures
  maintenance: trace lock acquisition failures

  parent reply	other threads:[~2026-11-04 17:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-01 10:59 [PATCH] maintenance: trace when auto maintenance skips due to lock Pushkar Singh
2026-11-02  8:29 ` Patrick Steinhardt
2026-11-02 12:23   ` Pushkar Singh
2026-11-02 12:29 ` [PATCH v2] maintenance: improve handling of lock acquisition failures Pushkar Singh
2026-11-02 12:51   ` Patrick Steinhardt
2026-11-03 17:34     ` Pushkar Singh
2026-11-04 17:34   ` Pushkar Singh [this message]
2026-11-04 17:34     ` [PATCH v3 1/2] maintenance: report " Pushkar Singh
2026-11-04 17:34     ` [PATCH v3 2/2] maintenance: trace " Pushkar Singh
2026-11-18 19:07     ` [PATCH v4 0/2] maintenance: improve lock acquisition failure handling Pushkar Singh
2026-11-18 19:07       ` [PATCH v4 1/2] maintenance: handle lock acquisition failures correctly Pushkar Singh
2026-11-18 19:07       ` [PATCH v4 2/2] maintenance: trace lock acquisition failures Pushkar Singh
2026-11-04 18:00   ` [PATCH v2] maintenance: improve handling of " Aniket Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261104173422.20725-1-pushkarkumarsingh1970@gmail.com \
    --to=pushkarkumarsingh1970@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mail@thomasbachem.com \
    --cc=ps@pks.im \
    --cc=ttaylorr@openai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox