Git development
 help / color / mirror / Atom feed
From: Cynthia Uche <herroyalpriestess@gmail.com>
To: karthik.188@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] api-parse-options: add missing flags and macros
Date: Thu,  5 Nov 2026 13:25:31 +0100	[thread overview]
Message-ID: <20261105122532.391-1-herroyalpriestess@gmail.com> (raw)
In-Reply-To: <20261105-kn-parse-options-doc-v1-1-403edda5947a@gmail.com>

Hi Karthik,

On Thu, Nov 5, 2026 at 11:37 AM Karthik Nayak <karthik.188@gmail.com> wrote:

> Also add the follow missing macros:

nit: s/follow/following/.

> - OPT_NO_WITH

The message lists OPT_NO_WITH, but parse-options.h defines
OPT_WITHOUT, which is what the diff documents. The diff also adds
OPT_BITOP, OPT_STRVEC, OPT_UYN, OPT_NOOP_ARG and OPT_COLUMN, which
the message doesn't list.

I applied this on its base (8d1b215c01), built the docs with no
warnings, and compared the descriptions with the code on master
(0ffa3e35c7). OPT__VERBOSITY, OPT_UYN, OPT_BITOP, OPT_COLUMN,
OPT_CONTAINS, OPT_NOOP_ARG and the two new flags match
parse-options.c and parse-options-cb.c, and the git-add[1]
references resolve via diff-context-options.adoc.

OPT_ALIAS and OPT_ALIAS_F are still undocumented tho. I wonder if that
is on purpose.

-- 
Cynthia

  reply	other threads:[~2026-11-05 12:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 10:31 [PATCH] api-parse-options: add missing flags and macros Karthik Nayak
2026-11-05 12:25 ` Cynthia Uche [this message]
2026-11-05 13:56   ` Karthik Nayak
2026-11-05 21:35     ` Cynthia Uche
2026-11-06  8:50 ` [PATCH v2] " Karthik Nayak
2026-11-06 19:53   ` Cynthia Uche
2026-11-09 11:30     ` Karthik Nayak
2026-11-09 11:30 ` [PATCH v3] " Karthik Nayak
2026-11-09 18:59   ` Junio C Hamano
2026-11-10 13:15     ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105122532.391-1-herroyalpriestess@gmail.com \
    --to=herroyalpriestess@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox