Git development
 help / color / mirror / Atom feed
From: Aniket Gupta <aniketgupta3001@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH v2] bundle-uri: do not die on unresolvable relative URIs
Date: Thu,  5 Nov 2026 15:29:06 +0000	[thread overview]
Message-ID: <20261105152906.566363-1-aniketgupta3001@gmail.com> (raw)
In-Reply-To: <auyH8BGzIsipPAJG@pks.im>

Hi Patrick,

Thanks for the review.

> This sentence is weird as it adds context that doesn't make sense
> standalone. [...] Saying something like "relative_url() is now a thin
> wrapper around that new function that continues to die, so existing
> callers continue to behave the same" would be way less surprising.

Makes sense, I used your wording.

> Would it have made sense to split this out into a separate commit?

Yes, I think so. It is three patches now: add relative_url_gently(),
hide the credentials in its error message, and then use it in
bundle-uri.

> Wouldn't it make sense in this case to grep for the exact URL
> printed, as the intent is to verify that we print the correct one? At
> that point, we can probably just compare the full message.

Agreed, the test compares the whole message now.

Aniket

      reply	other threads:[~2026-11-05 15:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 11:58 [PATCH] bundle-uri: do not die on unresolvable relative URIs Aniket Gupta
2026-11-03 13:04 ` Patrick Steinhardt
2026-11-03 15:55   ` Aniket Gupta
2026-11-03 15:52 ` [PATCH v2] " Aniket Gupta
2026-11-05 13:43   ` Patrick Steinhardt
2026-11-05 15:29     ` Aniket Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105152906.566363-1-aniketgupta3001@gmail.com \
    --to=aniketgupta3001@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox