Git development
 help / color / mirror / Atom feed
From: Aniket Gupta <aniketgupta3001@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Hannes Brandstätter-Müller" <hannes.mueller@gmail.com>,
	git@vger.kernel.org
Subject: Re: [BUG] git apply: pure rename followed by edit fails with core.fileMode=false
Date: Sat,  7 Nov 2026 04:07:15 +0000	[thread overview]
Message-ID: <20261107040715.436-1-aniketgupta3001@gmail.com> (raw)
In-Reply-To: <xmqqwlqpg0js.fsf@gitster.g>

Hi Junio,

The series in Hannes's report is valid input which is what format-patch
makes for a commit that renames a file followed by one which edits it.
My symlink example was hand made and not valid. I only wanted to
demonstrate that the type check no longer fires. This is a minor point.

I also tried undoing the series with -R (the edit first, then the
rename) for a plain and an exe file. It works the same with and without
the change.

Thanks,
Aniket

  reply	other threads:[~2026-11-07  4:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 13:53 [BUG] git apply: pure rename followed by edit fails with core.fileMode=false Hannes Brandstätter-Müller
2026-11-06 18:11 ` Aniket Gupta
2026-11-06 20:36   ` Junio C Hamano
2026-11-07  4:07     ` Aniket Gupta [this message]
2026-11-07  5:25       ` Junio C Hamano
2026-11-07  5:47         ` Aniket Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107040715.436-1-aniketgupta3001@gmail.com \
    --to=aniketgupta3001@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hannes.mueller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox