Git development
 help / color / mirror / Atom feed
From: Cynthia Uche <herroyalpriestess@gmail.com>
To: gitgitgadget@gmail.com
Cc: christian.couder@gmail.com, git@vger.kernel.org,
	gitster@pobox.com, herroyalpriestess@gmail.com,
	kaartic.sivaraam@gmail.com, shashu8660@gmail.com,
	siddharthasthana31@gmail.com, usmanakinyemi202@gmail.com
Subject: Re: [PATCH v3] test-chmtime: use parse_options() to parse command-line flags
Date: Mon,  9 Nov 2026 16:07:40 +0100	[thread overview]
Message-ID: <20261109150740.3003-1-herroyalpriestess@gmail.com> (raw)
In-Reply-To: <pull.2280.v3.git.1793639275978.gitgitgadget@gmail.com>

Hi Shashank,

I applied v3 on master (fb255012ac). t0082 passes 4 of 4, and the
negative-offset test fails if I set the PARSE_OPT_KEEP_UNKNOWN_OPT
argument to 0, so it guards that flag. The behaviour changes listed in
the commit message match what I see against a build of master.

Looks good. Thanks for adding the test and the commit message text.

-- 
Cynthia

      reply	other threads:[~2026-11-09 15:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 11:14 [PATCH] test-chmtime: use parse_options() to parse command-line flags Shashank S via GitGitGadget
2026-10-27 18:38 ` Junio C Hamano
2026-10-29  5:52   ` Shashank S
2026-10-27 18:48 ` Junio C Hamano
2026-10-29  5:54   ` Shashank S
2026-10-30  8:52 ` [PATCH v2] " Shashank S via GitGitGadget
2026-11-02  2:46   ` Cynthia Uche
2026-11-02  4:56     ` Shashank S
2026-11-02 17:07 ` [PATCH v3] " Shashank S via GitGitGadget
2026-11-09 15:07   ` Cynthia Uche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109150740.3003-1-herroyalpriestess@gmail.com \
    --to=herroyalpriestess@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=shashu8660@gmail.com \
    --cc=siddharthasthana31@gmail.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox