Git development
 help / color / mirror / Atom feed
From: Jakub Kulik <jakub.kulik@oracle.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Jakub Kulik <jakub.kulik@oracle.com>
Subject: [PATCH] t1017: add missing quotes
Date: Wed, 18 Nov 2026 16:59:35 +0100	[thread overview]
Message-ID: <20261118155935.60345-1-jakub.kulik@oracle.com> (raw)
In-Reply-To: <xmqqik21hiqi.fsf@gitster.g>

Signed-off-by: Jakub Kulik <jakub.kulik@oracle.com>
---
> Strictly speaking, POSIX compliant shells do not require such
> quoting for pathnames that are used as redirection target.

Indeed; when I run it with `bash --posix`, the test passes.

Here is the patch with space between > and the filename removed.

 t/t1017-cat-file-remote-object-info.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t1017-cat-file-remote-object-info.sh b/t/t1017-cat-file-remote-object-info.sh
index e2919aa061..8a04cfdae8 100755
--- a/t/t1017-cat-file-remote-object-info.sh
+++ b/t/t1017-cat-file-remote-object-info.sh
@@ -69,7 +69,7 @@ daemon_parent=$GIT_DAEMON_DOCUMENT_ROOT_PATH/parent
 
 test_expect_success 'create repo to be served by git-daemon' '
 	git init "$daemon_parent" &&
-	echo_without_newline "$hello_content" > $daemon_parent/hello &&
+	echo_without_newline "$hello_content" >"$daemon_parent/hello" &&
 	git -C "$daemon_parent" update-index --add hello &&
 	git -C "$daemon_parent" config transfer.advertiseobjectinfo true &&
 	git clone "$GIT_DAEMON_URL/parent" -n "$daemon_parent/daemon_client_empty"
@@ -519,7 +519,7 @@ test_expect_success 'create repo to be served by http:// transport' '
 	git init "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
 	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config http.receivepack true &&
 	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config transfer.advertiseobjectinfo true &&
-	echo_without_newline "$hello_content" > $HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello &&
+	echo_without_newline "$hello_content" >"$HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello" &&
 	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" update-index --add hello &&
 	git clone "$HTTPD_URL/smart/http_parent" -n "$HTTPD_DOCUMENT_ROOT_PATH/http_client_empty"
 '
-- 
2.51.0


  reply	other threads:[~2026-11-18 15:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 15:39 several unquoted shell variables causing test failures on Solaris Jakub Kulik
2026-11-12 20:56 ` Junio C Hamano
2026-11-18 15:59   ` Jakub Kulik [this message]
2026-11-18 17:08     ` [PATCH] t1017: add missing quotes Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118155935.60345-1-jakub.kulik@oracle.com \
    --to=jakub.kulik@oracle.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox